From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <insight-return-6985-listarch-insight=sources.redhat.com@sourceware.org>
Received: (qmail 23845 invoked by alias); 30 Mar 2012 13:10:25 -0000
Received: (qmail 23585 invoked by uid 22791); 30 Mar 2012 13:10:24 -0000
X-SWARE-Spam-Status: No, hits=-6.7 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Mar 2012 13:10:08 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2UDA4WC001227	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 30 Mar 2012 09:10:04 -0400
Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q2UDA1lT025364	(version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);	Fri, 30 Mar 2012 09:10:03 -0400
Message-ID: <4F75B0A9.1030609@redhat.com>
Date: Fri, 30 Mar 2012 13:10:00 -0000
From: Keith Seitz <keiths@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1
MIME-Version: 1.0
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
CC: insight@sourceware.org
Subject: Re: [PATCH] Add missing prototype in gdbtk.c
References: <4F67221F.2020906@onevision.com> <4F74E9F1.20804@redhat.com> <000701cd0e75$5e028b80$1a07a280$@muller@ics-cnrs.unistra.fr>
In-Reply-To: <000701cd0e75$5e028b80$1a07a280$@muller@ics-cnrs.unistra.fr>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact insight-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <insight.sourceware.org>
List-Subscribe: <mailto:insight-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/insight/>
List-Post: <mailto:insight@sourceware.org>
List-Help: <mailto:insight-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: insight-owner@sourceware.org
X-SW-Source: 2012-q1/txt/msg00054.txt.bz2

On 03/30/2012 06:02 AM, Pierre Muller wrote:
> I hope that I found the reason:
> Prototypes apparently require (void) instead of ().

That's interesting...

> The following patch fixes the problem for mingw32,
>
> Is this patch OK?
>

Sure, you could consider a clean-up like that obvious. [I try to use the 
same "rules" gdb uses. It's what I'm used to.]

Thank you, Pierre!

Keith