From: Keith Seitz <keiths@redhat.com>
To: Patrick Monnerat <Patrick.Monnerat@datasphere.ch>
Cc: insight@sourceware.org, roland@onevision.com
Subject: Re: [PATCH] print format does not match argument type
Date: Tue, 10 Apr 2012 16:28:00 -0000 [thread overview]
Message-ID: <4F845F7E.1010603@redhat.com> (raw)
In-Reply-To: <AB5E58B87EB73C46A38073D8F459F113D9F886@dataspheresrv01>
On 04/10/2012 09:08 AM, Patrick Monnerat wrote:
> I think I've found the universal (well: almost!) coding:
>
> Use format "%llx" and cast arg to (unsigned long long): This is C99 and
> supported by MSVC, at least since 2005. Not OK for C89 :-(
To be honest, I didn't even know that we did this. [The register code is
some of the oldest code in insight.] Passing host memory addresses into
the interpreter and back again as a string is just plain evil.
The C code should create a map/hashtable and store the pointers to the
types itself; then pass a string representation of the key into the
interpreter.
But for now, if your suggestion works (Roland will hopefully verify),
then I say we go with that for the time being.
Thank you!
Keith
next prev parent reply other threads:[~2012-04-10 16:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 14:30 Roland Schwingel
2012-04-10 15:10 ` Patrick Monnerat
2012-04-10 16:08 ` Patrick Monnerat
2012-04-10 16:28 ` Keith Seitz [this message]
2012-04-13 14:52 ` Pierre Muller
2012-04-13 15:18 ` Keith Seitz
2012-04-13 15:25 ` Pierre Muller
-- strict thread matches above, loose matches on Subject: below --
2012-04-11 11:38 Roland Schwingel
2012-04-11 17:24 ` Patrick Monnerat
2012-04-10 16:59 Roland Schwingel
2012-04-05 16:34 Patrick Monnerat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F845F7E.1010603@redhat.com \
--to=keiths@redhat.com \
--cc=Patrick.Monnerat@datasphere.ch \
--cc=insight@sourceware.org \
--cc=roland@onevision.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).