public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Roland Schwingel <roland@onevision.com>
To: insight@sourceware.org
Subject: Re: [PATCH/gdbtk] Make color of changed vars customizable v2
Date: Fri, 25 May 2012 10:42:00 -0000	[thread overview]
Message-ID: <4FBF61F7.900@onevision.com> (raw)

Hi ...

Thanks for reviewing Keith!

I applied all your wishes regarding formatting.

 > > @@ -54,7 +54,7 @@ itcl::body SrcPref::_build_win {} {
 > >     set w [$f.colors get_frame]
 > >
 > >     set color [pref get gdb/src/PC_TAG]
 > > -  label $w.pcl -text {PC}
 > > +  label $w.pcl -text {PC/Var change}
 > >     button $w.pcb -text {     } -activebackground $color -bg $color 
 > >       -command [code $this _pick $color $w.pcb PC_TAG]
 >
 > How about if we just use the more generic term, "Highlight"
 > instead of "PC/Var change"?
Changed the label to "Highlight". You are right this is the better term.

Committed the patch now.

Roland

             reply	other threads:[~2012-05-25 10:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-25 10:42 Roland Schwingel [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-04-11 12:27 Roland Schwingel
2012-05-24 21:08 ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBF61F7.900@onevision.com \
    --to=roland@onevision.com \
    --cc=insight@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).