From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16535 invoked by alias); 25 May 2012 10:42:32 -0000 Received: (qmail 16524 invoked by uid 22791); 25 May 2012 10:42:31 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from outdoor.onevision.de (HELO outdoor.onevision.de) (212.77.172.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 May 2012 10:42:10 +0000 Received: from sanders.onevision.de (moonrace [212.77.172.62]) by outdoor.onevision.de (8.14.3/8.13.7/ROSCH/DDB) with ESMTP id q4PAg4T2001902 for ; Fri, 25 May 2012 12:42:09 +0200 Received: from [192.168.5.32] ([192.168.5.32]) by sanders.onevision.de (Lotus Domino Release 8.5.1FP3) with ESMTP id 2012052512415904-39476 ; Fri, 25 May 2012 12:41:59 +0200 Message-ID: <4FBF61F7.900@onevision.com> Date: Fri, 25 May 2012 10:42:00 -0000 From: Roland Schwingel User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: insight@sourceware.org Subject: Re: [PATCH/gdbtk] Make color of changed vars customizable v2 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-15; format=flowed Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2012-q2/txt/msg00033.txt.bz2 Hi ... Thanks for reviewing Keith! I applied all your wishes regarding formatting. > > @@ -54,7 +54,7 @@ itcl::body SrcPref::_build_win {} { > > set w [$f.colors get_frame] > > > > set color [pref get gdb/src/PC_TAG] > > - label $w.pcl -text {PC} > > + label $w.pcl -text {PC/Var change} > > button $w.pcb -text { } -activebackground $color -bg $color > > -command [code $this _pick $color $w.pcb PC_TAG] > > How about if we just use the more generic term, "Highlight" > instead of "PC/Var change"? Changed the label to "Highlight". You are right this is the better term. Committed the patch now. Roland