From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28529 invoked by alias); 25 May 2012 11:36:55 -0000 Received: (qmail 28364 invoked by uid 22791); 25 May 2012 11:36:54 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,TW_BT,TW_DB X-Spam-Check-By: sourceware.org Received: from outdoor.onevision.de (HELO outdoor.onevision.de) (212.77.172.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 May 2012 11:36:32 +0000 Received: from sanders.onevision.de (moonrace [212.77.172.62]) by outdoor.onevision.de (8.14.3/8.13.7/ROSCH/DDB) with ESMTP id q4PBaQJm007148 for ; Fri, 25 May 2012 13:36:31 +0200 Received: from [192.168.5.32] ([192.168.5.32]) by sanders.onevision.de (Lotus Domino Release 8.5.1FP3) with ESMTP id 2012052513362100-39537 ; Fri, 25 May 2012 13:36:21 +0200 Message-ID: <4FBF6EB5.6000604@onevision.com> Date: Fri, 25 May 2012 11:36:00 -0000 From: Roland Schwingel User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: insight@sourceware.org Subject: [PATCH/gdbtk] Make gdbtk compile again Content-Type: multipart/mixed; boundary="------------010900010708030706060705" Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2012-q2/txt/msg00034.txt.bz2 This is a multi-part message in MIME format. --------------010900010708030706060705 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-length: 938 Hi... Due to recent changes in gdb's signal handling, the addition of dprintf and changes to blocks gdbtk was no longer compiling. I committed the attached simple patch to fix this. Changelog: 2012-05-25 Roland Schwingel * generic/gdbtk-bp.c (gdb_set_bp): Add new NULL param to call to create_breakpoint() due to changes in gdb. * generic/gdbtk-cmds.c (gdb_listfuncs): Iterator param in call to ALL_BLOCK_SYMBOLS() now is a pointer to struct block_iterator instead of struct dict_iterator. * generic/gdbtk-stack.c (gdb_block_vars,gdb_get_blocks) (gdb_get_vars_command): Likewise. * generic/gdbtk-hooks.c (gdbtk_annotate_signal): Change function calls: target_signal_to_name -> gdb_signal_to_name target_signal_to_string -> gdb_signal_to_string due to recent changes in gdb. I hope this was ok as it blocked reintegration of my other patches. Roland --------------010900010708030706060705 Content-Transfer-Encoding: 7bit Content-Type: text/plain; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-length: 2197 $svn diff Index: gdbtk-stack.c =================================================================== --- gdbtk-stack.c (revision 117583) +++ gdbtk-stack.c (working copy) @@ -92,7 +92,7 @@ int objc, Tcl_Obj *CONST objv[]) { struct block *block; - struct dict_iterator iter; + struct block_iterator iter; struct symbol *sym; CORE_ADDR start, end; @@ -162,7 +162,7 @@ int objc, Tcl_Obj *CONST objv[]) { struct block *block; - struct dict_iterator iter; + struct block_iterator iter; int junk; struct symbol *sym; CORE_ADDR pc; @@ -282,7 +282,7 @@ struct symbol *sym; struct block *block; char *args; - struct dict_iterator iter; + struct block_iterator iter; int i, arguments; if (objc > 2) Index: gdbtk-hooks.c =================================================================== --- gdbtk-hooks.c (revision 117583) +++ gdbtk-hooks.c (working copy) @@ -818,8 +818,8 @@ tp = inferior_thread (); buf = xstrprintf ("gdbtk_signal %s {%s}", - target_signal_to_name (tp->suspend.stop_signal), - target_signal_to_string (tp->suspend.stop_signal)); + gdb_signal_to_name (tp->suspend.stop_signal), + gdb_signal_to_string (tp->suspend.stop_signal)); if (Tcl_Eval (gdbtk_interp, buf) != TCL_OK) report_error (); free(buf); Index: gdbtk-cmds.c =================================================================== --- gdbtk-cmds.c (revision 117583) +++ gdbtk-cmds.c (working copy) @@ -1537,7 +1537,7 @@ struct block *b; struct symbol *sym; int i; - struct dict_iterator iter; + struct block_iterator iter; Tcl_Obj *funcVals[2]; if (objc != 2) Index: gdbtk-bp.c =================================================================== --- gdbtk-bp.c (revision 117583) +++ gdbtk-bp.c (working copy) @@ -535,6 +535,7 @@ TRY_CATCH (e, RETURN_MASK_ALL) { create_breakpoint (get_current_arch (), address, condition, thread, + NULL, 0 /* condition and thread are valid */, temp, bp_breakpoint /* type wanted */, --------------010900010708030706060705--