From: Roland Schwingel <roland@onevision.com>
To: insight@sourceware.org
Subject: Re: [PATCH/gdbtk] Implement "Attach to process" for windows
Date: Mon, 25 Jun 2012 12:14:00 -0000 [thread overview]
Message-ID: <4FE855F7.5050806@onevision.com> (raw)
Hi,
After some long detour back again at my computers...
> You have two choices here...
> 1) Leave this as-is, change attachdlg so that it checks if the return
> from gdb_list_processes is empty and fallback to groking ps.
> 2) return TCL_OK inside _WIN32 and return TCL_ERROR to force
> attachdlg to fallback to groking ps.
I opted for case 1) now and implemented it that way. I tested it
on windows and linux and attach to process seems to run nicely on
both platforms.
I committed the patch now with the formatting issue mentioned by Keith
corrected.
Roland
next reply other threads:[~2012-06-25 12:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 12:14 Roland Schwingel [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-04-11 15:12 Roland Schwingel
2012-05-24 23:30 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE855F7.5050806@onevision.com \
--to=roland@onevision.com \
--cc=insight@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).