From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5303 invoked by alias); 8 Aug 2012 13:54:28 -0000 Received: (qmail 5294 invoked by uid 22791); 8 Aug 2012 13:54:27 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,TW_BT,TW_DB X-Spam-Check-By: sourceware.org Received: from outdoor.onevision.de (HELO outdoor.onevision.de) (212.77.172.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 08 Aug 2012 13:54:14 +0000 Received: from sanders.onevision.de (moonrace [212.77.172.62]) by outdoor.onevision.de (8.14.3/8.13.7/ROSCH/DDB) with ESMTP id q78Ds8xI017415 for ; Wed, 8 Aug 2012 15:54:13 +0200 Received: from [192.168.5.32] ([192.168.5.32]) by sanders.onevision.de (Lotus Domino Release 8.5.1FP3) with ESMTP id 2012080815540306-116617 ; Wed, 8 Aug 2012 15:54:03 +0200 Message-ID: <50226F7A.8080206@onevision.com> Date: Wed, 08 Aug 2012 13:54:00 -0000 From: Roland Schwingel User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: insight@sourceware.org Subject: Make insight compileable again Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-15; format=flowed Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2012-q3/txt/msg00004.txt.bz2 Hi... Due to some changes some weeks ago in gdb current insight did no longer compile. I committed a small patch to fix this. cvs diff: Diffing . Index: ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/ChangeLog,v retrieving revision 1.480 diff -r1.480 ChangeLog 0a1,13 > 2012-08-08 Roland Schwingel > > * generic/gdbtk-cmds.c (gdb_load_info): Replace call to > make_cleanup_bfd_close with make_cleanup_bfd_unref due > to changes in gdb. > (gdb_loc): Replace call to decode_line_spec with call to > decode_line_with_current_source due to changes in gdb. > * generic/gdbtk-wrapper.c: Comment unused functions > GDB_parse_exp_1 and wrap_parse_exp_1 as parse_exp_1 has > changed its interface and the code appears to be unused > anyway. > * generic/gdbtk-wrapper.h: ditto > cvs diff: Diffing generic Index: generic/gdbtk-cmds.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v retrieving revision 1.127 diff -r1.127 gdbtk-cmds.c 971c971 < old_cleanups = make_cleanup_bfd_close (loadfile_bfd); --- > old_cleanups = make_cleanup_bfd_unref (loadfile_bfd); 2273c2273 < sals = decode_line_spec (Tcl_GetStringFromObj (objv[1], NULL), 1); --- > sals = decode_line_with_current_source (Tcl_GetStringFromObj (objv[1], NULL), 1); Index: generic/gdbtk-wrapper.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-wrapper.c,v retrieving revision 1.19 diff -r1.19 gdbtk-wrapper.c 47a48 > /* 49a51 > */ 105a108 > /* 106a110 > */ 301a306 > /* 335a341 > */ Index: generic/gdbtk-wrapper.h =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-wrapper.h,v retrieving revision 1.11 diff -r1.11 gdbtk-wrapper.h 66a67 > /* 68a70 > */ parse_exp_1() in gdb has changed parameter count. As I wanted to adjust this in insight I found this code to be unused. To get insight compiling again I commented the affected functions. If no one objects I will remove this code (most of the wrapper code seems to be unused) when back from my vacations which start in 10 minutes.... ;-) Roland