Make insight compileable again

Make insight compileable again

[Roland Schwingel]

Hi...

Due to some changes some weeks ago in gdb current insight did no
longer compile. I committed a small patch to fix this.

cvs diff: Diffing .
Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/ChangeLog,v
retrieving revision 1.480
diff -r1.480 ChangeLog
0a1,13
 > 2012-08-08  Roland Schwingel  <roland.schwingel@onevision.com>
 >
 >       * generic/gdbtk-cmds.c (gdb_load_info): Replace call to
 >       make_cleanup_bfd_close with make_cleanup_bfd_unref due
 >       to changes in gdb.
 >       (gdb_loc): Replace call to decode_line_spec with call to
 >       decode_line_with_current_source due to changes in gdb.
 >       * generic/gdbtk-wrapper.c: Comment unused functions
 >       GDB_parse_exp_1 and wrap_parse_exp_1 as parse_exp_1 has
 >       changed its interface and the code appears to be unused
 >       anyway.
 >       * generic/gdbtk-wrapper.h: ditto
 >
cvs diff: Diffing generic
Index: generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.127
diff -r1.127 gdbtk-cmds.c
971c971
<   old_cleanups = make_cleanup_bfd_close (loadfile_bfd);
---
 >   old_cleanups = make_cleanup_bfd_unref (loadfile_bfd);
2273c2273
<       sals = decode_line_spec (Tcl_GetStringFromObj (objv[1], NULL), 1);
---
 >       sals = decode_line_with_current_source (Tcl_GetStringFromObj 
(objv[1], NULL), 1);
Index: generic/gdbtk-wrapper.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-wrapper.c,v
retrieving revision 1.19
diff -r1.19 gdbtk-wrapper.c
47a48
 > /*
49a51
 > */
105a108
 > /*
106a110
 > */
301a306
 > /*
335a341
 > */
Index: generic/gdbtk-wrapper.h
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-wrapper.h,v
retrieving revision 1.11
diff -r1.11 gdbtk-wrapper.h
66a67
 > /*
68a70
 > */

parse_exp_1() in gdb has changed parameter count. As I wanted to adjust
this in insight I found this code to be unused. To get insight compiling
again I commented the affected functions. If no one objects I will 
remove this code (most of the wrapper code seems to be unused) when
back from my vacations which start in 10 minutes.... ;-)

Roland

Re: Make insight compileable again

[Keith Seitz]

On 08/08/2012 06:54 AM, Roland Schwingel wrote:

> Due to some changes some weeks ago in gdb current insight did no
> longer compile. I committed a small patch to fix this.

I've been remiss keeping up on this. I haven't actually attempted to 
compile insight in several weeks. I've been too busy debugging stuff!

>  > 2012-08-08  Roland Schwingel  <roland.schwingel@onevision.com>
>  >
>  >       * generic/gdbtk-cmds.c (gdb_load_info): Replace call to
>  >       make_cleanup_bfd_close with make_cleanup_bfd_unref due
>  >       to changes in gdb.
>  >       (gdb_loc): Replace call to decode_line_spec with call to
>  >       decode_line_with_current_source due to changes in gdb.
>  >       * generic/gdbtk-wrapper.c: Comment unused functions
>  >       GDB_parse_exp_1 and wrap_parse_exp_1 as parse_exp_1 has
>  >       changed its interface and the code appears to be unused
>  >       anyway.
>  >       * generic/gdbtk-wrapper.h: ditto
>  >

Those changes look ok.

> parse_exp_1() in gdb has changed parameter count. As I wanted to adjust
> this in insight I found this code to be unused. To get insight compiling
> again I commented the affected functions. If no one objects I will
> remove this code (most of the wrapper code seems to be unused) when
> back from my vacations which start in 10 minutes.... ;-)

I can look into that. Now that I've been prodded, I'll kick off a build 
and see what happens.

Keith