From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18467 invoked by alias); 8 Aug 2012 14:18:18 -0000 Received: (qmail 18457 invoked by uid 22791); 8 Aug 2012 14:18:16 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 08 Aug 2012 14:18:04 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q78EHq7p002354 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 8 Aug 2012 10:17:52 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q78EHnlk026754 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Wed, 8 Aug 2012 10:17:51 -0400 Message-ID: <5022750D.4050207@redhat.com> Date: Wed, 08 Aug 2012 14:18:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: Roland Schwingel CC: insight@sourceware.org Subject: Re: Make insight compileable again References: <50226F7A.8080206@onevision.com> In-Reply-To: <50226F7A.8080206@onevision.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2012-q3/txt/msg00005.txt.bz2 On 08/08/2012 06:54 AM, Roland Schwingel wrote: > Due to some changes some weeks ago in gdb current insight did no > longer compile. I committed a small patch to fix this. I've been remiss keeping up on this. I haven't actually attempted to compile insight in several weeks. I've been too busy debugging stuff! > > 2012-08-08 Roland Schwingel > > > > * generic/gdbtk-cmds.c (gdb_load_info): Replace call to > > make_cleanup_bfd_close with make_cleanup_bfd_unref due > > to changes in gdb. > > (gdb_loc): Replace call to decode_line_spec with call to > > decode_line_with_current_source due to changes in gdb. > > * generic/gdbtk-wrapper.c: Comment unused functions > > GDB_parse_exp_1 and wrap_parse_exp_1 as parse_exp_1 has > > changed its interface and the code appears to be unused > > anyway. > > * generic/gdbtk-wrapper.h: ditto > > Those changes look ok. > parse_exp_1() in gdb has changed parameter count. As I wanted to adjust > this in insight I found this code to be unused. To get insight compiling > again I commented the affected functions. If no one objects I will > remove this code (most of the wrapper code seems to be unused) when > back from my vacations which start in 10 minutes.... ;-) I can look into that. Now that I've been prodded, I'll kick off a build and see what happens. Keith