From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11454 invoked by alias); 10 Oct 2012 17:54:42 -0000 Received: (qmail 11395 invoked by uid 22791); 10 Oct 2012 17:54:40 -0000 X-SWARE-Spam-Status: No, hits=-7.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_BT,TW_DB X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 10 Oct 2012 17:54:34 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9AHsXxl007738 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 10 Oct 2012 13:54:33 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q9AHTVwO005007 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 10 Oct 2012 13:29:32 -0400 Message-ID: <5075B07B.6040106@redhat.com> Date: Wed, 10 Oct 2012 17:54:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: insight Subject: [PATCH] Update API changes causing build errors Content-Type: multipart/mixed; boundary="------------000906060301030901060805" X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2012-q4/txt/msg00000.txt.bz2 This is a multi-part message in MIME format. --------------000906060301030901060805 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 388 Hi, Gdb recently had some APIs updated, and insight was left unbuildable. This patch should correct any problems. Keith ChangeLog 2012-10-10 Keith Seitz * generic/gdbtk-hooks.c (gdbtk_memory_changed): Change LEN from int to ssize_t to match changes in the API. (x_event): Use set_quit_flag to set the quit_flag. * generic/gdbtk-cmds.c (gdb_stop): Likewise. --------------000906060301030901060805 Content-Type: text/x-patch; name="build-errors.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="build-errors.patch" Content-length: 2242 Index: generic/gdbtk-hooks.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-hooks.c,v retrieving revision 1.55 diff -u -p -r1.55 gdbtk-hooks.c --- generic/gdbtk-hooks.c 25 May 2012 11:36:08 -0000 1.55 +++ generic/gdbtk-hooks.c 10 Oct 2012 17:27:16 -0000 @@ -1,7 +1,7 @@ /* Startup code for Insight. Copyright (C) 1994, 1995, 1996, 1997, 1998, 2000, 200, 2002, 2003, 2004, - 2008, 2010, 2011 Free Software Foundation, Inc. + 2008, 2010, 2011, 2012 Free Software Foundation, Inc. Written by Stu Grossman of Cygnus Support. @@ -94,7 +94,7 @@ static void gdbtk_pre_add_symbol (const static void gdbtk_print_frame_info (struct symtab *, int, int, int); static void gdbtk_post_add_symbol (void); static void gdbtk_register_changed (int regno); -static void gdbtk_memory_changed (CORE_ADDR addr, int len, +static void gdbtk_memory_changed (CORE_ADDR addr, ssize_t len, const bfd_byte *data); static void gdbtk_selected_frame_changed (int); static void gdbtk_context_change (int); @@ -399,7 +399,7 @@ gdbtk_register_changed (int regno) } static void -gdbtk_memory_changed (CORE_ADDR addr, int len, const bfd_byte *data) +gdbtk_memory_changed (CORE_ADDR addr, ssize_t len, const bfd_byte *data) { if (Tcl_Eval (gdbtk_interp, "gdbtk_memory_changed") != TCL_OK) report_error (); @@ -472,7 +472,7 @@ x_event (int signo) } if ((Tcl_GetIntFromObj (gdbtk_interp, varname, &val) == TCL_OK) && val) { - quit_flag = 1; + set_quit_flag (); #ifdef REQUEST_QUIT REQUEST_QUIT; #else Index: generic/gdbtk-cmds.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v retrieving revision 1.128 diff -u -p -r1.128 gdbtk-cmds.c --- generic/gdbtk-cmds.c 8 Aug 2012 13:50:32 -0000 1.128 +++ generic/gdbtk-cmds.c 10 Oct 2012 17:27:17 -0000 @@ -598,7 +598,7 @@ gdb_stop (ClientData clientData, Tcl_Int if (target_ignore != (void (*) (void)) current_target.to_stop) target_stop (gdbtk_get_ptid ()); else - quit_flag = 1; /* hope something sees this */ + set_quit_flag (); /* hope something sees this */ } return TCL_OK; --------------000906060301030901060805--