public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: "Dave U. Random" <anonymous@anonymitaet-im-inter.net>
Cc: insight@sourceware.org
Subject: [PATCH] Fix build gdbtk-hooks.c problem [was Re: grossly out of date???]
Date: Wed, 24 Oct 2012 15:34:00 -0000	[thread overview]
Message-ID: <50880A78.4080200@redhat.com> (raw)
In-Reply-To: <45194155e4e3e08ad0ece41e62916c3b@anonymitaet-im-inter.net>

On 10/24/2012 03:59 AM, Dave U. Random wrote:
>
> Yes but the daily CVS is often broken. Like now, for instance :-(
>

That's my fault: Lately, I've been doing a lot of debugging (using 
insight, of course), and I haven't been keeping up on building from HEAD 
as often as I should.

Here is a patch which fixes the build problem. This is the only problem 
that I noticed. If there are others, please send a note to the list to 
draw my attention to it.

I do try to keep insight building/working.

Keith

ChangeLog
2012-10-24  Keith Seitz  <keiths@redhat.com>

	* generic/gdbtk-hooks.c (gdbtk_memory_changed): Update for
	API changes.

Index: generic/gdbtk-hooks.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-hooks.c,v
retrieving revision 1.56
diff -u -p -r1.56 gdbtk-hooks.c
--- generic/gdbtk-hooks.c	10 Oct 2012 17:28:03 -0000	1.56
+++ generic/gdbtk-hooks.c	24 Oct 2012 15:29:40 -0000
@@ -94,8 +94,8 @@ static void gdbtk_pre_add_symbol (const
  static void gdbtk_print_frame_info (struct symtab *, int, int, int);
  static void gdbtk_post_add_symbol (void);
  static void gdbtk_register_changed (int regno);
-static void gdbtk_memory_changed (CORE_ADDR addr, ssize_t len,
-				  const bfd_byte *data);
+static void gdbtk_memory_changed (struct inferior *inferior, CORE_ADDR 
addr,
+				  ssize_t len, const bfd_byte *data);
  static void gdbtk_selected_frame_changed (int);
  static void gdbtk_context_change (int);
  static void gdbtk_error_begin (void);
@@ -399,7 +399,8 @@ gdbtk_register_changed (int regno)
  }

  static void
-gdbtk_memory_changed (CORE_ADDR addr, ssize_t len, const bfd_byte *data)
+gdbtk_memory_changed (struct inferior *inferior, CORE_ADDR addr,
+		      ssize_t len, const bfd_byte *data)
  {
    if (Tcl_Eval (gdbtk_interp, "gdbtk_memory_changed") != TCL_OK)
      report_error ();

  reply	other threads:[~2012-10-24 15:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-24  6:40 grossly out of date??? Roland Schwingel
2012-10-24 10:59 ` Dave U. Random
2012-10-24 15:34   ` Keith Seitz [this message]
2012-10-24 17:24     ` [PATCH] Fix build gdbtk-hooks.c problem [was Re: grossly out of date???] Anonymous

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50880A78.4080200@redhat.com \
    --to=keiths@redhat.com \
    --cc=anonymous@anonymitaet-im-inter.net \
    --cc=insight@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).