From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29984 invoked by alias); 24 Oct 2012 15:34:31 -0000 Received: (qmail 29731 invoked by uid 22791); 24 Oct 2012 15:34:31 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_BT,TW_DB X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Oct 2012 15:34:21 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9OFYJcF004322 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 24 Oct 2012 11:34:19 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q9OFYGCr020093 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 24 Oct 2012 11:34:18 -0400 Message-ID: <50880A78.4080200@redhat.com> Date: Wed, 24 Oct 2012 15:34:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: "Dave U. Random" CC: insight@sourceware.org Subject: [PATCH] Fix build gdbtk-hooks.c problem [was Re: grossly out of date???] References: <45194155e4e3e08ad0ece41e62916c3b@anonymitaet-im-inter.net> In-Reply-To: <45194155e4e3e08ad0ece41e62916c3b@anonymitaet-im-inter.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2012-q4/txt/msg00007.txt.bz2 On 10/24/2012 03:59 AM, Dave U. Random wrote: > > Yes but the daily CVS is often broken. Like now, for instance :-( > That's my fault: Lately, I've been doing a lot of debugging (using insight, of course), and I haven't been keeping up on building from HEAD as often as I should. Here is a patch which fixes the build problem. This is the only problem that I noticed. If there are others, please send a note to the list to draw my attention to it. I do try to keep insight building/working. Keith ChangeLog 2012-10-24 Keith Seitz * generic/gdbtk-hooks.c (gdbtk_memory_changed): Update for API changes. Index: generic/gdbtk-hooks.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-hooks.c,v retrieving revision 1.56 diff -u -p -r1.56 gdbtk-hooks.c --- generic/gdbtk-hooks.c 10 Oct 2012 17:28:03 -0000 1.56 +++ generic/gdbtk-hooks.c 24 Oct 2012 15:29:40 -0000 @@ -94,8 +94,8 @@ static void gdbtk_pre_add_symbol (const static void gdbtk_print_frame_info (struct symtab *, int, int, int); static void gdbtk_post_add_symbol (void); static void gdbtk_register_changed (int regno); -static void gdbtk_memory_changed (CORE_ADDR addr, ssize_t len, - const bfd_byte *data); +static void gdbtk_memory_changed (struct inferior *inferior, CORE_ADDR addr, + ssize_t len, const bfd_byte *data); static void gdbtk_selected_frame_changed (int); static void gdbtk_context_change (int); static void gdbtk_error_begin (void); @@ -399,7 +399,8 @@ gdbtk_register_changed (int regno) } static void -gdbtk_memory_changed (CORE_ADDR addr, ssize_t len, const bfd_byte *data) +gdbtk_memory_changed (struct inferior *inferior, CORE_ADDR addr, + ssize_t len, const bfd_byte *data) { if (Tcl_Eval (gdbtk_interp, "gdbtk_memory_changed") != TCL_OK) report_error ();