public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Roland Schwingel <roland@onevision.com>
To: insight@sourceware.org
Subject: Recent tracepoint changes in gdb
Date: Mon, 05 Nov 2012 11:43:00 -0000	[thread overview]
Message-ID: <5097A647.7070203@onevision.com> (raw)

Hi...

Since November 3rd insight is no longer compiling against current gdb 
head sources. This is reasoned by changes to fix this bug:

http://sourceware.org/bugzilla/show_bug.cgi?id=14617

gdb removed the tracepoint observers. The single occurrance of 
observer_notify_tracepoint_modified() in breakpoint.c was moved to
observer_notify_breakpoint_modified().

I was investigating history...
There are 3 actions for dealing with tracepoints.
tracepoint_created
tracepoint_modified
tracepoint_deleted

I was searching gdb 6.8/7.0/7.3/head and I could only find
the tracepoint_modified action to be used ever.

Thus this leads me the conclusion that the WHOLE tracepoint
support in insight could be removed at all.

A quick fix to get insight to compile again would be to remove the 
observer attaching in gdbtk-hooks.c for the 3 tracepoint hooks but it 
might be cleaner to remove the existing tracepoint support at all.

Or am I missing something here?

Roland






             reply	other threads:[~2012-11-05 11:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-05 11:43 Roland Schwingel [this message]
2012-11-05 15:37 ` Keith Seitz
2012-11-10 17:51   ` Keith Seitz
2012-11-10 18:10     ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5097A647.7070203@onevision.com \
    --to=roland@onevision.com \
    --cc=insight@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).