From: Keith Seitz <keiths@redhat.com>
To: insight@sourceware.org
Subject: Re: Recent tracepoint changes in gdb
Date: Sat, 10 Nov 2012 18:10:00 -0000 [thread overview]
Message-ID: <509E9870.60906@redhat.com> (raw)
In-Reply-To: <509E93E4.3060000@redhat.com>
On 11/10/2012 09:50 AM, Keith Seitz wrote:
> On 11/05/2012 07:37 AM, Keith Seitz wrote:
>> Thanks for pointing this out, I will work on a patch.
>
> Here is the patch. Let me know if there are any further difficulties.
Gah! And there was a logic bug in that patch. This patch fixes that.
Keith
ChangeLog
2012-11-10 Keith Seitz <keiths@redhat.com>
* generic/gdbtk-bp.c (breakpoint_notify): Fix logic error
when detecting breakpoint types to be handled.
diff --git a/gdb/gdbtk/generic/gdbtk-bp.c b/gdb/gdbtk/generic/gdbtk-bp.c
index 8e752f1..c6e2df9 100644
--- a/gdb/gdbtk/generic/gdbtk-bp.c
+++ b/gdb/gdbtk/generic/gdbtk-bp.c
@@ -605,9 +605,9 @@ breakpoint_notify (int num, const char *action)
if (b->number < 0
/* FIXME: should not be so restrictive... */
- && b->type != bp_breakpoint
- && b->type != bp_tracepoint
- && b->type != bp_fast_tracepoint)
+ || (b->type != bp_breakpoint
+ && b->type != bp_tracepoint
+ && b->type != bp_fast_tracepoint))
return;
/* We ensure that ACTION contains no special Tcl characters, so we
prev parent reply other threads:[~2012-11-10 18:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 11:43 Roland Schwingel
2012-11-05 15:37 ` Keith Seitz
2012-11-10 17:51 ` Keith Seitz
2012-11-10 18:10 ` Keith Seitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509E9870.60906@redhat.com \
--to=keiths@redhat.com \
--cc=insight@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).