From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20370 invoked by alias); 10 Nov 2012 18:10:05 -0000 Received: (qmail 20350 invoked by uid 22791); 10 Nov 2012 18:10:02 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 10 Nov 2012 18:09:55 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAAI9sWI003391 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 10 Nov 2012 13:09:54 -0500 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qAAI9qcU023876 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Sat, 10 Nov 2012 13:09:54 -0500 Message-ID: <509E9870.60906@redhat.com> Date: Sat, 10 Nov 2012 18:10:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: insight@sourceware.org Subject: Re: Recent tracepoint changes in gdb References: <5097A647.7070203@onevision.com> <5097DD26.60802@redhat.com> <509E93E4.3060000@redhat.com> In-Reply-To: <509E93E4.3060000@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2012-q4/txt/msg00014.txt.bz2 On 11/10/2012 09:50 AM, Keith Seitz wrote: > On 11/05/2012 07:37 AM, Keith Seitz wrote: >> Thanks for pointing this out, I will work on a patch. > > Here is the patch. Let me know if there are any further difficulties. Gah! And there was a logic bug in that patch. This patch fixes that. Keith ChangeLog 2012-11-10 Keith Seitz * generic/gdbtk-bp.c (breakpoint_notify): Fix logic error when detecting breakpoint types to be handled. diff --git a/gdb/gdbtk/generic/gdbtk-bp.c b/gdb/gdbtk/generic/gdbtk-bp.c index 8e752f1..c6e2df9 100644 --- a/gdb/gdbtk/generic/gdbtk-bp.c +++ b/gdb/gdbtk/generic/gdbtk-bp.c @@ -605,9 +605,9 @@ breakpoint_notify (int num, const char *action) if (b->number < 0 /* FIXME: should not be so restrictive... */ - && b->type != bp_breakpoint - && b->type != bp_tracepoint - && b->type != bp_fast_tracepoint) + || (b->type != bp_breakpoint + && b->type != bp_tracepoint + && b->type != bp_fast_tracepoint)) return; /* We ensure that ACTION contains no special Tcl characters, so we