From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3988 invoked by alias); 16 Feb 2013 17:07:48 -0000 Received: (qmail 3977 invoked by uid 22791); 16 Feb 2013 17:07:47 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 16 Feb 2013 17:07:42 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1GH7f6s007753 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 16 Feb 2013 12:07:41 -0500 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r1GH7eq6002824 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Sat, 16 Feb 2013 12:07:41 -0500 Message-ID: <511FBCDC.60803@redhat.com> Date: Sat, 16 Feb 2013 17:07:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: insight Subject: [PATCH] Use Tcl_SetObjResult in rhabout plugin Content-Type: multipart/mixed; boundary="------------080302000606020806090303" X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2013-q1/txt/msg00023.txt.bz2 This is a multi-part message in MIME format. --------------080302000606020806090303 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 331 Hi, While mucking around with Tcl 8.6, the compiler noticed that I'd missed one place where the code was directly setting the interpreter's result. This patch fixes that. Keith 2013-02-16 Keith Seitz * rhabout.c (extra_text): Use Tcl_SetObjResult instead of setting the interpreter's result directly. --------------080302000606020806090303 Content-Type: text/x-patch; name="rhabout.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="rhabout.patch" Content-length: 592 Index: rhabout.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/plugins/rhabout/rhabout.c,v retrieving revision 1.2 diff -u -p -r1.2 rhabout.c --- rhabout.c 8 Dec 2004 20:21:08 -0000 1.2 +++ rhabout.c 16 Feb 2013 17:03:35 -0000 @@ -22,7 +22,8 @@ extra_text (ClientData clientData, Tcl_Interp *interp, int objc, Tcl_Obj *CONST objv[]) { - interp->result = "\nThis is a sample plug-in\n"; + Tcl_SetObjResult (interp, + Tcl_NewStringObj ("\nThis is a sample plug-in\n", -1)); return TCL_OK; } --------------080302000606020806090303--