From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21037 invoked by alias); 5 Jun 2013 20:27:08 -0000 Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org Received: (qmail 21020 invoked by uid 89); 5 Jun 2013 20:27:08 -0000 X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS,TW_BT,TW_DB autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 05 Jun 2013 20:27:07 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r55KR5RI018380 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 5 Jun 2013 16:27:05 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r55KR4CN029666 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 5 Jun 2013 16:27:05 -0400 Message-ID: <51AF9F18.2050305@redhat.com> Date: Wed, 05 Jun 2013 20:27:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 MIME-Version: 1.0 To: insight Subject: [PATCH] char -> gdb_byte Content-Type: multipart/mixed; boundary="------------000406060006020403020904" X-Virus-Found: No X-SW-Source: 2013-q2/txt/msg00016.txt.bz2 This is a multi-part message in MIME format. --------------000406060006020403020904 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 438 Hi, A recent audit of gdb caught some problems with char vs gdb_byte correctness. This introduced a build problem. The following patch attempts to address this. Keith ChangeLog 2013-06-05 Keith Seitz * generic/gdbtk-register.c (map_arg_registers): Change type of raw_buffer to gdb_byte to follow recent API changes in gdb. * generic/gdbtk-cmds.c (gdb_update_mem): Likewise for ' mbfu', 'mptr', and 'cptr'. --------------000406060006020403020904 Content-Type: text/x-patch; name="gdb_byte.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="gdb_byte.patch" Content-length: 1851 Index: generic/gdbtk-cmds.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v retrieving revision 1.132 diff -u -p -r1.132 gdbtk-cmds.c --- generic/gdbtk-cmds.c 5 Jun 2013 20:19:46 -0000 1.132 +++ generic/gdbtk-cmds.c 5 Jun 2013 20:23:56 -0000 @@ -2477,7 +2477,8 @@ gdb_update_mem (ClientData clientData, T int max_ascii_len, max_val_len, max_label_len; char format, aschar; char *data, *tmp; - char buff[128], *mbuf, *mptr, *cptr, *bptr; + char buff[128], *bptr; + gdb_byte *mbuf, *mptr, *cptr; struct ui_file *stb; struct type *val_type; struct cleanup *old_chain; @@ -2535,7 +2536,7 @@ gdb_update_mem (ClientData clientData, T addr = string_to_core_addr (tmp); format = *(Tcl_GetStringFromObj (objv[3], NULL)); - mbuf = (char *) xmalloc (nbytes + 32); + mbuf = (gdb_byte *) xmalloc (nbytes + 32); if (!mbuf) { gdbtk_set_result (interp, "Out of memory."); Index: generic/gdbtk-register.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-register.c,v retrieving revision 1.44 diff -u -p -r1.44 gdbtk-register.c --- generic/gdbtk-register.c 21 Nov 2012 16:39:33 -0000 1.44 +++ generic/gdbtk-register.c 5 Jun 2013 20:23:56 -0000 @@ -1,5 +1,5 @@ /* Tcl/Tk command definitions for Insight - Registers - Copyright (C) 2001-2012 Free Software Foundation, Inc. + Copyright (C) 2001-2013 Free Software Foundation, Inc. This file is part of GDB. @@ -442,7 +442,7 @@ map_arg_registers (Tcl_Interp *interp, i static void register_changed_p (int regnum, map_arg arg) { - char raw_buffer[MAX_REGISTER_SIZE]; + gdb_byte raw_buffer[MAX_REGISTER_SIZE]; if (!target_has_registers || !deprecated_frame_register_read (get_selected_frame (NULL), regnum, --------------000406060006020403020904--