On 07/02/2013 02:41 AM, John Long wrote:
> Hello. I just pulled the latest CVS sources and the build is breaking. After
> it didn't work I did make again and captured the output so I could post to
> the list:
> gcc -g -O2   -I. -I. -I./common -I./config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I./../include/opcode -I./../opcodes/.. -I./../readline/.. -I../bfd -I./../bfd -I./../include -I../libdecnumber -I./../libdecnumber  -I./gnulib/import -Ibuild-gnulib/import   -DTUI=1  -DGDBTK -I/usr/include/python2.7 -I/usr/include/python2.7 -Wall -Wdeclaration-after-statement -Wpointer-arith -Wpointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement -Wempty-body -Wmissing-parameter-type -Wold-style-declaration -Wold-style-definition -Wformat-nonliteral -Werror -c -o gdbtk.o -MT gdbtk.o -MMD -MP -MF .deps/gdbtk.Tpo -I./../libgui/src    -I/tmp/insight-cvs/src/tcl/generic -I/tmp/insight-cvs/src/tk/generic   -DGDBTK_LIBRARY=\"/usr/local/share/insight1.0\" -DSRC_DIR=\"/tmp/insight-cvs/src/gdb\" ./gdbtk/generic/gdbtk.c
> ./gdbtk/generic/gdbtk.c: In function 'gdbtk_interactive':
> ./gdbtk/generic/gdbtk.c:253:1: error: old-style function definition [-Werror=old-style-definition]
> ./gdbtk/generic/gdbtk.c: In function 'gdbtk_start_timer':
> ./gdbtk/generic/gdbtk.c:260:1: error: old-style function definition [-Werror=old-style-definition]
> ./gdbtk/generic/gdbtk.c: In function 'gdbtk_stop_timer':
> ./gdbtk/generic/gdbtk.c:307:1: error: old-style function definition [-Werror=old-style-definition]
> ./gdbtk/generic/gdbtk.c: In function '_initialize_gdbtk':
> ./gdbtk/generic/gdbtk.c:691:1: error: old-style function definition [-Werror=old-style-definition]
> cc1: all warnings being treated as errors

Thank you for reporting this. This is occurring as a result of a patch 
checked into gdb yesterday.

I've applied the attached patch to drag insight into the 21st century 
(minimal kicking and screaming).

Keith

ChangeLog
2013-07-02  Keith Seitz  <keiths@redhat.com>

	* generic/gdbtk-cmds.c (gdb_listfuncs): Update declaration.
	* generic/gdbtk-hooks.c (gdb_two_elem_cmd): Likewise.
	(report_error): Likewise.
	(gdbtk_readline_end, gdbtk_post_add_symbol, gdbtk_error_begin,
	gdbtk_attach): Likewise.
	* generic/gdbtk/gdbtk-register.c (setup_architecture_data):
	Likewise.
	* generic/gdbtk-wrapper.c (GDB_equal_value, GDB_reinit_frame_cache,
	GDB_value-coerce_array): Likewise.
	* generic/gdbtk.c (gdbtk_interactive, gdbtk_start_timer,
	gdbtk_stop_timer, _initialize_gdbtk): Likewise.