From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25515 invoked by alias); 2 Jul 2013 17:07:57 -0000 Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org Received: (qmail 25499 invoked by uid 89); 2 Jul 2013 17:07:57 -0000 X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS,TW_BT,TW_DB,TW_GJ autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 02 Jul 2013 17:07:55 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r62H7mHZ028064 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 2 Jul 2013 13:07:48 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r62H7kpC028378 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Tue, 2 Jul 2013 13:07:48 -0400 Message-ID: <51D308E2.2010000@redhat.com> Date: Tue, 02 Jul 2013 17:07:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: John Long CC: insight@sourceware.org Subject: Re: Error building from cvs References: <20130702094150.GA18316@inbox.lv> In-Reply-To: <20130702094150.GA18316@inbox.lv> Content-Type: multipart/mixed; boundary="------------050904070203090702030500" X-Virus-Found: No X-SW-Source: 2013-q3/txt/msg00001.txt.bz2 This is a multi-part message in MIME format. --------------050904070203090702030500 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 2596 On 07/02/2013 02:41 AM, John Long wrote: > Hello. I just pulled the latest CVS sources and the build is breaking. After > it didn't work I did make again and captured the output so I could post to > the list: > gcc -g -O2 -I. -I. -I./common -I./config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I./../include/opcode -I./../opcodes/.. -I./../readline/.. -I../bfd -I./../bfd -I./../include -I../libdecnumber -I./../libdecnumber -I./gnulib/import -Ibuild-gnulib/import -DTUI=1 -DGDBTK -I/usr/include/python2.7 -I/usr/include/python2.7 -Wall -Wdeclaration-after-statement -Wpointer-arith -Wpointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement -Wempty-body -Wmissing-parameter-type -Wold-style-declaration -Wold-style-definition -Wformat-nonliteral -Werror -c -o gdbtk.o -MT gdbtk.o -MMD -MP -MF .deps/gdbtk.Tpo -I./../libgui/src -I/tmp/insight-cvs/src/tcl/generic -I/tmp/insight-cvs/src/tk/generic -DGDBTK_LIBRARY=\"/usr/local/share/insight1.0\" -DSRC_DIR=\"/tmp/insight-cvs/src/gdb\" ./gdbtk/generic/gdbtk.c > ./gdbtk/generic/gdbtk.c: In function 'gdbtk_interactive': > ./gdbtk/generic/gdbtk.c:253:1: error: old-style function definition [-Werror=old-style-definition] > ./gdbtk/generic/gdbtk.c: In function 'gdbtk_start_timer': > ./gdbtk/generic/gdbtk.c:260:1: error: old-style function definition [-Werror=old-style-definition] > ./gdbtk/generic/gdbtk.c: In function 'gdbtk_stop_timer': > ./gdbtk/generic/gdbtk.c:307:1: error: old-style function definition [-Werror=old-style-definition] > ./gdbtk/generic/gdbtk.c: In function '_initialize_gdbtk': > ./gdbtk/generic/gdbtk.c:691:1: error: old-style function definition [-Werror=old-style-definition] > cc1: all warnings being treated as errors Thank you for reporting this. This is occurring as a result of a patch checked into gdb yesterday. I've applied the attached patch to drag insight into the 21st century (minimal kicking and screaming). Keith ChangeLog 2013-07-02 Keith Seitz * generic/gdbtk-cmds.c (gdb_listfuncs): Update declaration. * generic/gdbtk-hooks.c (gdb_two_elem_cmd): Likewise. (report_error): Likewise. (gdbtk_readline_end, gdbtk_post_add_symbol, gdbtk_error_begin, gdbtk_attach): Likewise. * generic/gdbtk/gdbtk-register.c (setup_architecture_data): Likewise. * generic/gdbtk-wrapper.c (GDB_equal_value, GDB_reinit_frame_cache, GDB_value-coerce_array): Likewise. * generic/gdbtk.c (gdbtk_interactive, gdbtk_start_timer, gdbtk_stop_timer, _initialize_gdbtk): Likewise. --------------050904070203090702030500 Content-Type: text/x-patch; name="old-style-defn.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="old-style-defn.patch" Content-length: 5071 diff --git a/gdb/gdbtk/generic/gdbtk-cmds.c b/gdb/gdbtk/generic/gdbtk-cmds.c index 9b6a67e..42f2b1e 100644 --- a/gdb/gdbtk/generic/gdbtk-cmds.c +++ b/gdb/gdbtk/generic/gdbtk-cmds.c @@ -1528,11 +1528,8 @@ gdb_search (ClientData clientData, Tcl_Interp *interp, */ static int -gdb_listfuncs (clientData, interp, objc, objv) - ClientData clientData; - Tcl_Interp *interp; - int objc; - Tcl_Obj *CONST objv[]; +gdb_listfuncs (ClientData clientData, Tcl_Interp *interp, + int objc, Tcl_Obj *CONST objv[]) { struct symtab *symtab; struct blockvector *bv; diff --git a/gdb/gdbtk/generic/gdbtk-hooks.c b/gdb/gdbtk/generic/gdbtk-hooks.c index e1445e9..4aa8d06 100644 --- a/gdb/gdbtk/generic/gdbtk-hooks.c +++ b/gdb/gdbtk/generic/gdbtk-hooks.c @@ -194,9 +194,7 @@ gdbtk_restore_result_ptr (void *old_result_ptr) /* This allows you to Tcl_Eval a tcl command which takes a command word, and then a single argument. */ int -gdbtk_two_elem_cmd (cmd_name, argv1) - char *cmd_name; - char *argv1; +gdbtk_two_elem_cmd (char *cmd_name, char *argv1) { char *command; int result, flags_ptr, arg_len, cmd_len; @@ -364,7 +362,7 @@ gdbtk_warning (const char *warning, va_list args) /* the gdbtk dbug command. */ void -report_error () +report_error (void) { TclDebug ('E', Tcl_GetVar (gdbtk_interp, "errorInfo", TCL_GLOBAL_ONLY)); /* Tcl_BackgroundError(gdbtk_interp); */ @@ -518,7 +516,7 @@ gdbtk_readline (char *prompt) } static void -gdbtk_readline_end () +gdbtk_readline_end (void) { if (Tcl_Eval (gdbtk_interp, "gdbtk_tcl_readline_end") != TCL_OK) report_error (); @@ -644,7 +642,7 @@ gdbtk_pre_add_symbol (const char *name) /* This hook is called whenever we finish loading a symbol file. */ static void -gdbtk_post_add_symbol () +gdbtk_post_add_symbol (void) { if (Tcl_Eval (gdbtk_interp, "gdbtk_tcl_post_add_symbol") != TCL_OK) report_error (); @@ -783,7 +781,7 @@ gdbtk_exec_file_display (char *filename) /* Called from error_begin, this hook is used to warn the gui about multi-line error messages */ static void -gdbtk_error_begin () +gdbtk_error_begin (void) { if (result_ptr != NULL) result_ptr->flags |= GDBTK_ERROR_ONLY; @@ -816,7 +814,7 @@ gdbtk_annotate_signal (void) } static void -gdbtk_attach () +gdbtk_attach (void) { if (Tcl_Eval (gdbtk_interp, "after idle \"update idletasks;gdbtk_attached\"") != TCL_OK) { @@ -825,7 +823,7 @@ gdbtk_attach () } static void -gdbtk_detach () +gdbtk_detach (void) { if (Tcl_Eval (gdbtk_interp, "gdbtk_detached") != TCL_OK) { diff --git a/gdb/gdbtk/generic/gdbtk-register.c b/gdb/gdbtk/generic/gdbtk-register.c index 8f40d94..4f95c89 100644 --- a/gdb/gdbtk/generic/gdbtk-register.c +++ b/gdb/gdbtk/generic/gdbtk-register.c @@ -462,7 +462,7 @@ register_changed_p (int regnum, map_arg arg) } static void -setup_architecture_data () +setup_architecture_data (void) { int numregs; diff --git a/gdb/gdbtk/generic/gdbtk-wrapper.c b/gdb/gdbtk/generic/gdbtk-wrapper.c index 491ffa3..8e0fc87 100644 --- a/gdb/gdbtk/generic/gdbtk-wrapper.c +++ b/gdb/gdbtk/generic/gdbtk-wrapper.c @@ -1,5 +1,5 @@ /* longjmp-free interface between gdb and gdbtk. - Copyright (C) 1999, 2000, 2002, 2008 Free Software Foundation, Inc. + Copyright (C) 1999, 2000, 2002, 2008, 2013 Free Software Foundation, Inc. This file is part of GDB. @@ -271,10 +271,7 @@ wrap_evaluate_expression (char *a) } gdb_result -GDB_value_equal (val1, val2, result) - value_ptr val1; - value_ptr val2; - int *result; +GDB_value_equal (value_ptr val1, value_ptr val2, int *result) { struct gdb_wrapper_arguments args; gdb_result r; @@ -422,7 +419,7 @@ wrap_block_innermost_frame (char *opaque_arg) } gdb_result -GDB_reinit_frame_cache () +GDB_reinit_frame_cache (void) { gdb_result r; @@ -500,9 +497,7 @@ wrap_value_slice (char *opaque_arg) } gdb_result -GDB_value_coerce_array (val, rval) - value_ptr val; - value_ptr *rval; +GDB_value_coerce_array (value_ptr val, value_ptr *rval) { struct gdb_wrapper_arguments args; gdb_result r; diff --git a/gdb/gdbtk/generic/gdbtk.c b/gdb/gdbtk/generic/gdbtk.c index d205347..ea13943 100644 --- a/gdb/gdbtk/generic/gdbtk.c +++ b/gdb/gdbtk/generic/gdbtk.c @@ -250,14 +250,14 @@ cleanup_init (void *ignore) via the QUIT macro. */ void -gdbtk_interactive () +gdbtk_interactive (void) { /* Tk_DoOneEvent (TK_DONT_WAIT|TK_IDLE_EVENTS); */ } /* Start a timer which will keep the GUI alive while in target_wait. */ void -gdbtk_start_timer () +gdbtk_start_timer (void) { static int first = 1; @@ -304,7 +304,7 @@ gdbtk_start_timer () /* Stop the timer if it is running. */ void -gdbtk_stop_timer () +gdbtk_stop_timer (void) { if (gdbtk_timer_going) { @@ -688,7 +688,7 @@ gdbtk_test (char *filename) /* Come here during initialize_all_files () */ void -_initialize_gdbtk () +_initialize_gdbtk (void) { /* Current_interpreter not set yet, so we must check if "interpreter_p" is set to "insight" to know if --------------050904070203090702030500--