Build problems again

Build problems again

[Fedin Pavel]

 Hello! One more build problem appeared:

--- cut ---
gcc -O2 -isystem /mingw/include -D__USE_MINGW_ACCESS   -I. -I. -I./common
-I./config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H
-I./../include/opcode -I./../opcodes
/.. -I./../readline/.. -I../bfd -I./../bfd -I./../include -I../libdecnumber
-I./../libdecnumber  -I./gnulib/import -Ibuild-gnulib/import   -DGDBTK
-I/mingw/include  -Wall -Wdeclar
ation-after-statement -Wpointer-arith -Wpointer-sign -Wno-unused
-Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts
-Wmissing-prototypes -Wdeclaration-after-stateme
nt -Wempty-body -Wmissing-parameter-type -Wold-style-declaration
-Wold-style-definition -Wno-format -Werror -c -o gdbtk.o -MT gdbtk.o -MMD
-MP -MF .deps/gdbtk.Tpo -I./../libgui/sr
c    -I/E/Projects/insight/src/tcl/generic
-I/E/Projects/insight/src/tk/generic -I"/E/Projects/insight/src/tk/xlib"
-DGDBTK_LIBRARY=\"/usr/local/share/insight1.0\" -DSRC_DIR=\"/E
/Projects/insight/src/gdb\" ./gdbtk/generic/gdbtk.c
cc1.exe: warnings being treated as errors
./gdbtk/generic/gdbtk.c: In function 'close_bfds':
./gdbtk/generic/gdbtk.c:168:1: error: old-style function definition
make: *** [gdbtk.o] Error 1
--- cut ---
 Fixed by changing function definition to:
--- cut ---
void
close_bfds (void)
--- cut ---
(added explicit 'void' in arguments). The error is reported by gcc 4.5.2.
 

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia

Re: Build problems again

[Keith Seitz]

On 07/15/2013 03:01 AM, Fedin Pavel wrote:
>   Hello! One more build problem appeared:

Thank you for pointing this out. I apologize that it has taken me this 
long to commit.

Keith

2013-07-23  Keith Seitz  <keiths@redhat.com>

	* generic/gdbtk.c (close_bfds): Update declaration.

Index: gdbtk/generic/gdbtk.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk.c,v
retrieving revision 1.55
diff -u -p -r1.55 gdbtk.c
--- gdbtk/generic/gdbtk.c	2 Jul 2013 17:07:29 -0000	1.55
+++ gdbtk/generic/gdbtk.c	23 Jul 2013 16:38:20 -0000
@@ -165,7 +165,7 @@ TclpFree (char *ptr)
   */

  void
-close_bfds ()
+close_bfds (void)
  {
    struct objfile *o;