* gdbtk-cmds.c is no longer compiling
@ 2013-07-26 9:26 Roland Schwingel
2013-07-26 15:31 ` Keith Seitz
0 siblings, 1 reply; 3+ messages in thread
From: Roland Schwingel @ 2013-07-26 9:26 UTC (permalink / raw)
To: insight
Hi...
Yesterday Tom Tromey removed in gdb's target.c function pop_target()
which is in use by gdb_clear_file() in gdbtk-cmds.c.
Yet I could not spot a suitable replacement to pop_target() so I cannot
propose a patch to make insight compiling again.
For myself I have resurrected pop_target() again.
Any clue on how to continue here?
Roland
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: gdbtk-cmds.c is no longer compiling
2013-07-26 9:26 gdbtk-cmds.c is no longer compiling Roland Schwingel
@ 2013-07-26 15:31 ` Keith Seitz
2013-07-30 23:17 ` Keith Seitz
0 siblings, 1 reply; 3+ messages in thread
From: Keith Seitz @ 2013-07-26 15:31 UTC (permalink / raw)
To: Roland Schwingel; +Cc: insight
On 07/26/2013 02:26 AM, Roland Schwingel wrote:
> Any clue on how to continue here?
I think you can just delete that block. It may no longer be necessary.
Give that a try and see if it makes any difference. I didn't notice a
difference here.
Keith
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: gdbtk-cmds.c is no longer compiling
2013-07-26 15:31 ` Keith Seitz
@ 2013-07-30 23:17 ` Keith Seitz
0 siblings, 0 replies; 3+ messages in thread
From: Keith Seitz @ 2013-07-30 23:17 UTC (permalink / raw)
To: insight
[-- Attachment #1: Type: text/plain, Size: 558 bytes --]
On 07/26/2013 08:31 AM, Keith Seitz wrote:
> On 07/26/2013 02:26 AM, Roland Schwingel wrote:
>> Any clue on how to continue here?
>
> I think you can just delete that block. It may no longer be necessary.
>
> Give that a try and see if it makes any difference. I didn't notice a
> difference here.
Well, it seems to work for me, so I've committed this to get the build
working again.
Keith
ChangeLog
2013-07-30 Keith Seitz <keiths@redhat.com>
* generic/gdbtk-cmds.c (gdb_clear_file): Remove use of pop_target,
which was recently removed from gdb.
[-- Attachment #2: pop_target.patch --]
[-- Type: text/x-patch, Size: 537 bytes --]
Index: generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.134
diff -u -p -r1.134 gdbtk-cmds.c
--- generic/gdbtk-cmds.c 2 Jul 2013 17:07:29 -0000 1.134
+++ generic/gdbtk-cmds.c 30 Jul 2013 23:13:11 -0000
@@ -487,9 +487,6 @@ gdb_clear_file (ClientData clientData, T
target_kill ();
}
- if (target_has_execution)
- pop_target ();
-
delete_command (NULL, 0);
exec_file_clear (0);
symbol_file_clear (0);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-30 23:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-26 9:26 gdbtk-cmds.c is no longer compiling Roland Schwingel
2013-07-26 15:31 ` Keith Seitz
2013-07-30 23:17 ` Keith Seitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).