public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: insight@sourceware.org
Subject: Re: gdbtk-cmds.c is no longer compiling
Date: Tue, 30 Jul 2013 23:17:00 -0000	[thread overview]
Message-ID: <51F84967.5050102@redhat.com> (raw)
In-Reply-To: <51F2963D.4070306@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

On 07/26/2013 08:31 AM, Keith Seitz wrote:
> On 07/26/2013 02:26 AM, Roland Schwingel wrote:
>> Any clue on how to continue here?
>
> I think you can just delete that block. It may no longer be necessary.
>
> Give that a try and see if it makes any difference. I didn't notice a
> difference here.

Well, it seems to work for me, so I've committed this to get the build 
working again.

Keith

ChangeLog
2013-07-30  Keith Seitz  <keiths@redhat.com>

	* generic/gdbtk-cmds.c (gdb_clear_file): Remove use of pop_target,
	which was recently removed from gdb.



[-- Attachment #2: pop_target.patch --]
[-- Type: text/x-patch, Size: 537 bytes --]

Index: generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.134
diff -u -p -r1.134 gdbtk-cmds.c
--- generic/gdbtk-cmds.c	2 Jul 2013 17:07:29 -0000	1.134
+++ generic/gdbtk-cmds.c	30 Jul 2013 23:13:11 -0000
@@ -487,9 +487,6 @@ gdb_clear_file (ClientData clientData, T
 	target_kill ();
     }
 
-  if (target_has_execution)
-    pop_target ();
-
   delete_command (NULL, 0);
   exec_file_clear (0);
   symbol_file_clear (0);

      reply	other threads:[~2013-07-30 23:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-26  9:26 Roland Schwingel
2013-07-26 15:31 ` Keith Seitz
2013-07-30 23:17   ` Keith Seitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F84967.5050102@redhat.com \
    --to=keiths@redhat.com \
    --cc=insight@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).