From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22683 invoked by alias); 30 Jul 2013 23:17:05 -0000 Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org Received: (qmail 22653 invoked by uid 89); 30 Jul 2013 23:17:04 -0000 X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_20,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 30 Jul 2013 23:17:03 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6UNGu13011944 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 30 Jul 2013 19:16:56 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r6UNGtdi025690 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Tue, 30 Jul 2013 19:16:56 -0400 Message-ID: <51F84967.5050102@redhat.com> Date: Tue, 30 Jul 2013 23:17:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: insight@sourceware.org Subject: Re: gdbtk-cmds.c is no longer compiling References: <51F240B9.1000709@onevision.com> <51F2963D.4070306@redhat.com> In-Reply-To: <51F2963D.4070306@redhat.com> Content-Type: multipart/mixed; boundary="------------080202000405040505040408" X-Virus-Found: No X-SW-Source: 2013-q3/txt/msg00021.txt.bz2 This is a multi-part message in MIME format. --------------080202000405040505040408 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Content-length: 558 On 07/26/2013 08:31 AM, Keith Seitz wrote: > On 07/26/2013 02:26 AM, Roland Schwingel wrote: >> Any clue on how to continue here? > > I think you can just delete that block. It may no longer be necessary. > > Give that a try and see if it makes any difference. I didn't notice a > difference here. Well, it seems to work for me, so I've committed this to get the build working again. Keith ChangeLog 2013-07-30 Keith Seitz * generic/gdbtk-cmds.c (gdb_clear_file): Remove use of pop_target, which was recently removed from gdb. --------------080202000405040505040408 Content-Type: text/x-patch; name="pop_target.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="pop_target.patch" Content-length: 537 Index: generic/gdbtk-cmds.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v retrieving revision 1.134 diff -u -p -r1.134 gdbtk-cmds.c --- generic/gdbtk-cmds.c 2 Jul 2013 17:07:29 -0000 1.134 +++ generic/gdbtk-cmds.c 30 Jul 2013 23:13:11 -0000 @@ -487,9 +487,6 @@ gdb_clear_file (ClientData clientData, T target_kill (); } - if (target_has_execution) - pop_target (); - delete_command (NULL, 0); exec_file_clear (0); symbol_file_clear (0); --------------080202000405040505040408--