From: Keith Seitz <keiths@redhat.com>
To: Andrew Burgess <aburgess@broadcom.com>
Cc: insight@sourceware.org
Subject: Re: [PATCH 2/2] Notice architecture changes even when the register window is not open.
Date: Thu, 05 Sep 2013 19:53:00 -0000 [thread overview]
Message-ID: <5228D4B7.2020908@redhat.com> (raw)
In-Reply-To: <522894D1.3030209@broadcom.com>
On 09/05/2013 07:27 AM, Andrew Burgess wrote:
> I think this a bad situation to be in as, the reg-cache would ideally
> be hidden from the user of "gdb_reginfo", and secondly, we only
> really need to update the reg-cache once per architecture change, not
> many times, which could happen if many users are all trying to keep
> the reg-cache upto date.
Ouch. I believe at the time, this was never considered. I'm not even
sure if it was possible. Nonetheless, it clearly *is* possible now, so
thank you for tracking this down.
BTW, what architecture are you using to trigger this bug?
> Anyway, let me know what you think, all feedback welcome.
One little comment below.
> Index: ./gdb/gdbtk/library/interface.tcl
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/interface.tcl,v
> retrieving revision 1.60
> diff -u -p -r1.60 interface.tcl
> --- ./gdb/gdbtk/library/interface.tcl 9 Oct 2009 01:23:55 -0000 1.60
> +++ ./gdb/gdbtk/library/interface.tcl 5 Sep 2013 14:19:53 -0000
> @@ -1815,6 +1815,9 @@ proc initialize_gdbtk {} {
> # The architecture changed. Inform the UI.
> proc gdbtk_tcl_architecture_changed {} {
> set e [ArchChangedEvent \#auto]
> + # First perform global actions as a result of the architecture change.
> + gdb_reg_arch_changed $e
> + # Now dispatch to all the other even handlers.
typo ("even[t] handlers")
> GDBEventHandler::dispatch $e
> delete object $e
> }
Okay with that change.
Keith
next prev parent reply other threads:[~2013-09-05 19:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 14:24 [PATCH 0/2] Memory corruption caused by failure to notice architecture change Andrew Burgess
2013-09-05 14:26 ` [PATCH 1/2] Add an assert that we're not overflowing the register cache Andrew Burgess
2013-09-05 18:55 ` Keith Seitz
2013-09-06 9:36 ` Andrew Burgess
2013-09-05 14:27 ` [PATCH 2/2] Notice architecture changes even when the register window is not open Andrew Burgess
2013-09-05 19:53 ` Keith Seitz [this message]
2013-09-06 9:21 ` Andrew Burgess
2013-09-06 9:40 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5228D4B7.2020908@redhat.com \
--to=keiths@redhat.com \
--cc=aburgess@broadcom.com \
--cc=insight@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).