From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32617 invoked by alias); 5 Sep 2013 19:53:16 -0000 Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org Received: (qmail 32597 invoked by uid 89); 5 Sep 2013 19:53:15 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Sep 2013 19:53:15 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r85J081h027579 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 5 Sep 2013 15:00:23 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r85J07xY006080 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 5 Sep 2013 15:00:08 -0400 Message-ID: <5228D4B7.2020908@redhat.com> Date: Thu, 05 Sep 2013 19:53:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Andrew Burgess CC: insight@sourceware.org Subject: Re: [PATCH 2/2] Notice architecture changes even when the register window is not open. References: <5228941F.8080601@broadcom.com> <522894D1.3030209@broadcom.com> In-Reply-To: <522894D1.3030209@broadcom.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-q3/txt/msg00038.txt.bz2 On 09/05/2013 07:27 AM, Andrew Burgess wrote: > I think this a bad situation to be in as, the reg-cache would ideally > be hidden from the user of "gdb_reginfo", and secondly, we only > really need to update the reg-cache once per architecture change, not > many times, which could happen if many users are all trying to keep > the reg-cache upto date. Ouch. I believe at the time, this was never considered. I'm not even sure if it was possible. Nonetheless, it clearly *is* possible now, so thank you for tracking this down. BTW, what architecture are you using to trigger this bug? > Anyway, let me know what you think, all feedback welcome. One little comment below. > Index: ./gdb/gdbtk/library/interface.tcl > =================================================================== > RCS file: /cvs/src/src/gdb/gdbtk/library/interface.tcl,v > retrieving revision 1.60 > diff -u -p -r1.60 interface.tcl > --- ./gdb/gdbtk/library/interface.tcl 9 Oct 2009 01:23:55 -0000 1.60 > +++ ./gdb/gdbtk/library/interface.tcl 5 Sep 2013 14:19:53 -0000 > @@ -1815,6 +1815,9 @@ proc initialize_gdbtk {} { > # The architecture changed. Inform the UI. > proc gdbtk_tcl_architecture_changed {} { > set e [ArchChangedEvent \#auto] > + # First perform global actions as a result of the architecture change. > + gdb_reg_arch_changed $e > + # Now dispatch to all the other even handlers. typo ("even[t] handlers") > GDBEventHandler::dispatch $e > delete object $e > } Okay with that change. Keith