From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <insight-return-7176-listarch-insight=sources.redhat.com@sourceware.org>
Received: (qmail 24414 invoked by alias); 6 Sep 2013 09:40:29 -0000
Mailing-List: contact insight-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <insight.sourceware.org>
List-Subscribe: <mailto:insight-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/insight/>
List-Post: <mailto:insight@sourceware.org>
List-Help: <mailto:insight-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: insight-owner@sourceware.org
Received: (qmail 24405 invoked by uid 89); 6 Sep 2013 09:40:29 -0000
Received: from mms2.broadcom.com (HELO mms2.broadcom.com) (216.31.210.18) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Sep 2013 09:40:29 +0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RDNS_NONE autolearn=no version=3.3.2
X-HELO: mms2.broadcom.com
Received: from [10.9.208.57] by mms2.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Fri, 06 Sep 2013 02:33:57 -0700
X-Server-Uuid: 4500596E-606A-40F9-852D-14843D8201B2
Received: from IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) by IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server (TLS) id 14.1.438.0; Fri, 6 Sep 2013 02:37:17 -0700
Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) with Microsoft SMTP Server id 14.1.438.0; Fri, 6 Sep 2013 02:37:17 -0700
Received: from [10.177.73.74] (unknown [10.177.73.74]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 6BF9D1A46; Fri, 6 Sep 2013 02:37:17 -0700 (PDT)
Message-ID: <5229A24C.7020104@broadcom.com>
Date: Fri, 06 Sep 2013 09:40:00 -0000
From: "Andrew Burgess" <aburgess@broadcom.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
MIME-Version: 1.0
To: insight@sourceware.org
cc: "Keith Seitz" <keiths@redhat.com>
Subject: Re: [PATCH 2/2] Notice architecture changes even when the register window is not open.
References: <5228941F.8080601@broadcom.com> <522894D1.3030209@broadcom.com> <5228D4B7.2020908@redhat.com>
In-Reply-To: <5228D4B7.2020908@redhat.com>
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2013-q3/txt/msg00041.txt.bz2

On 05/09/2013 8:00 PM, Keith Seitz wrote:
> On 09/05/2013 07:27 AM, Andrew Burgess wrote:
> 
> One little comment below.
> 
>> Index: ./gdb/gdbtk/library/interface.tcl
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/gdbtk/library/interface.tcl,v
>> retrieving revision 1.60
>> diff -u -p -r1.60 interface.tcl
>> --- ./gdb/gdbtk/library/interface.tcl    9 Oct 2009 01:23:55 -0000   
>> 1.60
>> +++ ./gdb/gdbtk/library/interface.tcl    5 Sep 2013 14:19:53 -0000
>> @@ -1815,6 +1815,9 @@ proc initialize_gdbtk {} {
>>   # The architecture changed. Inform the UI.
>>   proc gdbtk_tcl_architecture_changed {} {
>>     set e [ArchChangedEvent \#auto]
>> +  # First perform global actions as a result of the architecture change.
>> +  gdb_reg_arch_changed $e
>> +  # Now dispatch to all the other even handlers.
> 
> typo ("even[t] handlers")

Fixed.

> 
>>     GDBEventHandler::dispatch $e
>>     delete object $e
>>   }
> 
> Okay with that change.

Applied.

Thanks,
Andrew