From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22975 invoked by alias); 18 Sep 2013 14:17:09 -0000 Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org Received: (qmail 22955 invoked by uid 89); 18 Sep 2013 14:17:08 -0000 Received: from mms2.broadcom.com (HELO mms2.broadcom.com) (216.31.210.18) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Sep 2013 14:17:08 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.0 required=5.0 tests=AWL,BAYES_50,RDNS_NONE autolearn=no version=3.3.2 X-HELO: mms2.broadcom.com Received: from [10.9.208.57] by mms2.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Wed, 18 Sep 2013 07:10:29 -0700 X-Server-Uuid: 4500596E-606A-40F9-852D-14843D8201B2 Received: from IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) by IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server (TLS) id 14.1.438.0; Wed, 18 Sep 2013 07:16:54 -0700 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) with Microsoft SMTP Server id 14.1.438.0; Wed, 18 Sep 2013 07:16:54 -0700 Received: from [10.177.73.74] (unknown [10.177.73.74]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 3D3F6246A5 for ; Wed, 18 Sep 2013 07:16:54 -0700 (PDT) Message-ID: <5239B5D5.3090006@broadcom.com> Date: Wed, 18 Sep 2013 14:17:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: insight@sourceware.org Subject: [PATCH] Remove use of deprecated_frame_register_read Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-q3/txt/msg00043.txt.bz2 Continuing the theme of removing deprecated_* things, this patch removes the use of deprecated_frame_register_read, there's only one of them. OK to apply? Thanks, Andrew 2013-09-18 Andrew Burgess * generic/gdbtk-register.c (register_changed_p): Replace use of deprecated_frame_register_read with get_frame_register_value. diff -u -p -r1.49 gdbtk-register.c --- ./gdb/gdbtk/generic/gdbtk-register.c 6 Sep 2013 09:23:00 -0000 1.49 +++ ./gdb/gdbtk/generic/gdbtk-register.c 18 Sep 2013 13:26:40 -0000 @@ -443,21 +443,25 @@ map_arg_registers (Tcl_Interp *interp, i static void register_changed_p (int regnum, map_arg arg) { - gdb_byte raw_buffer[MAX_REGISTER_SIZE]; + struct value *val; gdb_assert (regnum < old_regs_count); - if (!target_has_registers - || !deprecated_frame_register_read (get_selected_frame (NULL), regnum, - raw_buffer)) + if (!target_has_registers) return; + + val = get_frame_register_value (get_selected_frame (NULL), regnum); + if (value_optimized_out (val) || !value_entirely_available (val)) + return; - if (memcmp (&old_regs[regnum * MAX_REGISTER_SIZE], raw_buffer, + if (memcmp (&old_regs[regnum * MAX_REGISTER_SIZE], + value_contents_all (val), register_size (get_current_arch (), regnum)) == 0) return; /* Found a changed register. Save new value and return its number. */ - memcpy (&old_regs[regnum * MAX_REGISTER_SIZE], raw_buffer, + memcpy (&old_regs[regnum * MAX_REGISTER_SIZE], + value_contents_all (val), register_size (get_current_arch (), regnum)); Tcl_ListObjAppendElement (NULL, result_ptr->obj_ptr, Tcl_NewIntObj (regnum));