* [PATCH] Remove use of deprecated_frame_register_read
@ 2013-09-18 14:17 Andrew Burgess
[not found] ` <523B94D9.6070907@redhat.com>
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Burgess @ 2013-09-18 14:17 UTC (permalink / raw)
To: insight
Continuing the theme of removing deprecated_* things, this
patch removes the use of deprecated_frame_register_read,
there's only one of them.
OK to apply?
Thanks,
Andrew
2013-09-18 Andrew Burgess <aburgess@broadcom.com>
* generic/gdbtk-register.c (register_changed_p): Replace use of
deprecated_frame_register_read with get_frame_register_value.
diff -u -p -r1.49 gdbtk-register.c
--- ./gdb/gdbtk/generic/gdbtk-register.c 6 Sep 2013 09:23:00 -0000 1.49
+++ ./gdb/gdbtk/generic/gdbtk-register.c 18 Sep 2013 13:26:40 -0000
@@ -443,21 +443,25 @@ map_arg_registers (Tcl_Interp *interp, i
static void
register_changed_p (int regnum, map_arg arg)
{
- gdb_byte raw_buffer[MAX_REGISTER_SIZE];
+ struct value *val;
gdb_assert (regnum < old_regs_count);
- if (!target_has_registers
- || !deprecated_frame_register_read (get_selected_frame (NULL), regnum,
- raw_buffer))
+ if (!target_has_registers)
return;
+
+ val = get_frame_register_value (get_selected_frame (NULL), regnum);
+ if (value_optimized_out (val) || !value_entirely_available (val))
+ return;
- if (memcmp (&old_regs[regnum * MAX_REGISTER_SIZE], raw_buffer,
+ if (memcmp (&old_regs[regnum * MAX_REGISTER_SIZE],
+ value_contents_all (val),
register_size (get_current_arch (), regnum)) == 0)
return;
/* Found a changed register. Save new value and return its number. */
- memcpy (&old_regs[regnum * MAX_REGISTER_SIZE], raw_buffer,
+ memcpy (&old_regs[regnum * MAX_REGISTER_SIZE],
+ value_contents_all (val),
register_size (get_current_arch (), regnum));
Tcl_ListObjAppendElement (NULL, result_ptr->obj_ptr, Tcl_NewIntObj (regnum));
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove use of deprecated_frame_register_read
[not found] ` <523B94D9.6070907@redhat.com>
@ 2013-09-20 11:51 ` Andrew Burgess
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Burgess @ 2013-09-20 11:51 UTC (permalink / raw)
To: insight; +Cc: Keith Seitz
On 20/09/2013 1:20 AM, Keith Seitz wrote:
> On 09/18/2013 07:16 AM, Andrew Burgess wrote:
>> Continuing the theme of removing deprecated_* things, this
>> patch removes the use of deprecated_frame_register_read,
>> there's only one of them.
>>
>> OK to apply?
>
> With the two small nits mentioned below checked/fixed, please commit,
> and again, thank you for your help.
Both fixed and committed.
Thanks for reviewing.
Andrew
>> diff -u -p -r1.49 gdbtk-register.c
>> --- ./gdb/gdbtk/generic/gdbtk-register.c 6 Sep 2013 09:23:00
>> -0000 1.49
>> +++ ./gdb/gdbtk/generic/gdbtk-register.c 18 Sep 2013 13:26:40 -0000
>> @@ -443,21 +443,25 @@ map_arg_registers (Tcl_Interp *interp, i
>> static void
>> register_changed_p (int regnum, map_arg arg)
>> {
>> - gdb_byte raw_buffer[MAX_REGISTER_SIZE];
>> + struct value *val;
>> gdb_assert (regnum < old_regs_count);
>>
>> - if (!target_has_registers
>> - || !deprecated_frame_register_read (get_selected_frame (NULL),
>> regnum,
>> - raw_buffer))
>> + if (!target_has_registers)
>> return;
>> +
>
> (1/2) This line looks like it has trailing whitespace. Could you
> double-check?
>
>> + val = get_frame_register_value (get_selected_frame (NULL), regnum);
>> + if (value_optimized_out (val) || !value_entirely_available (val))
>> + return;
>
> (2/2) So does this line.
>
>>
>> - if (memcmp (&old_regs[regnum * MAX_REGISTER_SIZE], raw_buffer,
>> + if (memcmp (&old_regs[regnum * MAX_REGISTER_SIZE],
>> + value_contents_all (val),
>> register_size (get_current_arch (), regnum)) == 0)
>> return;
>>
>> /* Found a changed register. Save new value and return its
>> number. */
>>
>> - memcpy (&old_regs[regnum * MAX_REGISTER_SIZE], raw_buffer,
>> + memcpy (&old_regs[regnum * MAX_REGISTER_SIZE],
>> + value_contents_all (val),
>> register_size (get_current_arch (), regnum));
>>
>> Tcl_ListObjAppendElement (NULL, result_ptr->obj_ptr, Tcl_NewIntObj
>> (regnum));
>>
>
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-20 11:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-18 14:17 [PATCH] Remove use of deprecated_frame_register_read Andrew Burgess
[not found] ` <523B94D9.6070907@redhat.com>
2013-09-20 11:51 ` Andrew Burgess
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).