From: Keith Seitz <keiths@redhat.com>
To: Tom Tromey <tromey@redhat.com>, Insight List <insight@sourceware.org>
Subject: Re: [PATCH] use an observer instead of deprecated_file_changed_hook
Date: Tue, 07 Jan 2014 20:03:00 -0000 [thread overview]
Message-ID: <52CC5D85.8030400@redhat.com> (raw)
In-Reply-To: <871u0jhamf.fsf@fleche.redhat.com>
On 01/07/2014 11:09 AM, Tom Tromey wrote:
> I think it works ok. I tested it by running the "file" command in the
> console and seeing whether insight reacted. I'm not totally sure
> whether this is a sufficient check, though.
With the additional checks you've added in the observer function, this
should work.
The standard test (IIRC -- I haven't tried this in years) is to start
insight on one executable, debug it a bit (run, step, step, step) with
some open data windows, then load an entirely new executable. If that
runs and the displays all show the new executable's state, then all is
probably good. I believe I also then followed with "file" (no
executable), which should simple clear state and "empty" all the windows.
From discussions on IRC, this use case is preserved. So that's good
enough for me.
Thank you for the patch!
Keith
next prev parent reply other threads:[~2014-01-07 20:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 19:09 Tom Tromey
2014-01-07 20:03 ` Keith Seitz [this message]
2014-01-09 17:13 ` Tom Tromey
2014-01-09 17:25 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CC5D85.8030400@redhat.com \
--to=keiths@redhat.com \
--cc=insight@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).