From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 21E053858D20 for ; Sat, 21 Jan 2023 20:55:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 21E053858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 8938C10040638 for ; Sat, 21 Jan 2023 20:55:55 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id JKu3psKrhNX2aJKu3pffaO; Sat, 21 Jan 2023 20:55:55 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=63cc515b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=TomFiwRUbc5Go4TAwgUA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From:Sender :Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=dAOkwLZJEeS/sb9Fxu3IF7+W0MFVuBLcjo/rv19Scok=; b=hzvn5aimdFc2sLviukxHL4hmo6 QnxT4mgF6AhZdf3w/Gj9MPhEOnhx4kyFbh8e7uBtLnpfRqqu2++5xA+1G0QTJQMcupUHxqZtqZ9Fm +dOv1NwDF67IejjbS8mM+IZNL; Received: from [161.98.8.3] (port=35154 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pJKu3-002FO8-8A; Sat, 21 Jan 2023 13:55:55 -0700 From: Tom Tromey To: insight@sourceware.org Subject: Sending patches upstream X-Attribution: Tom Date: Sat, 21 Jan 2023 13:55:50 -0700 Message-ID: <877cxfli95.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 161.98.8.3 X-Source-L: No X-Exim-ID: 1pJKu3-002FO8-8A X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (prentzel) [161.98.8.3]:35154 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi. I was looking through the Insight repo today and I think a couple patches could go upstream: * 003-tclconfig.patch * 004-tcltkplatform.patch * 007-gdbtk-obj-in-subdir.patch As long as some gdbtk build stuff lives in upstream gdb, it should probably just be directly patched there. I'd somewhat prefer a variant that makes SUBDIR_GDBTK_OBS be computed like the other _OBS variables, e.g.: SUBDIR_CLI_OBS = $(patsubst %.c,%.o,$(SUBDIR_CLI_SRCS)) However it might also make sense to just remove all the Tcl and gdbtk configure and build code upstream, to be added back and maintained in Insight... * 009-windows-stop.patch I think this can just go in with a suitable commit message. It seems like a clear oversight. I don't particularly understand why gdb needs both 'stop' and 'interrupt' methods, though. thanks, Tom