From: Tom Tromey <tromey@cygnus.com>
To: Syd Polk <spolk@redhat.com>
Cc: Insight List <insight@sourceware.cygnus.com>
Subject: Re: comment in managedwin.itb
Date: Tue, 28 Nov 2000 20:17:00 -0000 [thread overview]
Message-ID: <87ofyz2yk9.fsf@creche.cygnus.com> (raw)
In-Reply-To: <4.2.0.58.20001128130236.01acbbb0@pop.cygnus.com>
Syd> I hate commented it out code. I think you should restore the
Syd> command and give a concise comment about why you are not using
Syd> focus $top.
Actually, I think we shouldn't use focus at all.
* Using focus -force is unfriendly. It steals the focus, which the
user might not want.
* Using focus is pointless since it just moves the potential focus
point in that window. In general we don't want to do that.
How about this?
2000-11-28 Tom Tromey <tromey@cygnus.com>
* managedwin.itb (ManagedWin::reveal): Don't set focus.
Tom
Index: managedwin.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/managedwin.itb,v
retrieving revision 1.4
diff -u -r1.4 managedwin.itb
--- managedwin.itb 2000/03/29 03:18:16 1.4
+++ managedwin.itb 2000/11/29 04:16:39
@@ -40,11 +40,6 @@
set top [winfo toplevel [namespace tail $this]]
raise $top
wm deiconify $top
-
- # I don't understand this next line and no one commented it, so it's gone.
- #focus -force [focus -lastfor $top]
-
- focus $top
}
body ManagedWin::restart {} {
next prev parent reply other threads:[~2000-11-28 20:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-28 12:47 Tom Tromey
2000-11-28 12:54 ` Mo DeJong
2000-11-28 13:00 ` Syd Polk
2000-11-28 13:08 ` Keith Seitz
2000-11-28 13:16 ` Fernando Nasser
2000-11-28 20:17 ` Tom Tromey [this message]
2000-11-29 9:40 ` Fernando Nasser
2000-12-07 14:18 ` Fernando Nasser
2000-12-07 14:40 ` Tom Tromey
2000-12-07 15:15 ` Fernando Nasser
[not found] <975459464.28425.ezmlm@sources.redhat.com>
2000-11-28 19:19 ` Jim Ingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ofyz2yk9.fsf@creche.cygnus.com \
--to=tromey@cygnus.com \
--cc=insight@sourceware.cygnus.com \
--cc=spolk@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).