From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tom Tromey <tromey@cygnus.com>
To: Insight List <insight@sourceware.cygnus.com>
Subject: broken code
Date: Thu, 30 Nov 2000 19:51:00 -0000
Message-id: <87u28osscd.fsf@creche.cygnus.com>
X-SW-Source: 2000-q4/msg00347.html

I see this in gdbtk-hooks.c:

  xasprintf (&buf, "gdbtk_tcl_breakpoint %s %d 0x%lx %d {%s} {%s} %d %d",
	   action, b->number, (long) b->address, b->line_number, filename,
	   bpdisp[b->disposition], b->enable, b->thread);

In general, code like this is simply broken.  Using `{%s}' works for
some situations, but not others.  It seems to work, since it works in
the common cases, but it makes gdbtk less robust.

If you need to build a list, you should use the Tcl DString functions.

Maybe everybody working on the code already knows this.  I don't know.
I didn't look to see who writes this sort of thing (I'd rather not
know :-).

Tom