From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <insight-return-7282-listarch-insight=sources.redhat.com@sourceware.org>
Received: (qmail 102208 invoked by alias); 10 Oct 2019 00:20:33 -0000
Mailing-List: contact insight-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <insight.sourceware.org>
List-Subscribe: <mailto:insight-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/insight/>
List-Post: <mailto:insight@sourceware.org>
List-Help: <mailto:insight-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: insight-owner@sourceware.org
Received: (qmail 102196 invoked by uid 89); 10 Oct 2019 00:20:32 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=us!, us
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Oct 2019 00:20:31 +0000
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id B02E630BB370;	Thu, 10 Oct 2019 00:20:30 +0000 (UTC)
Received: from theo.uglyboxes.com (ovpn-116-199.phx2.redhat.com [10.3.116.199])	by smtp.corp.redhat.com (Postfix) with ESMTPS id 6199919C7F;	Thu, 10 Oct 2019 00:20:30 +0000 (UTC)
Subject: Re: [PATCH] Add declarations to gdbtk.h
To: Christian Biesinger <cbiesinger@google.com>, insight@sourceware.org
Cc: Christian Biesinger <cbiesinger@chromium.org>
References: <20191007210928.239798-1-cbiesinger@google.com>
From: Keith Seitz <keiths@redhat.com>
Message-ID: <9d348976-d7bc-3ff3-9e68-026cbb997194@redhat.com>
Date: Thu, 10 Oct 2019 00:20:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20191007210928.239798-1-cbiesinger@google.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2019-q4/txt/msg00004.txt.bz2

On 10/7/19 2:09 PM, Christian Biesinger via insight wrote:
> From: Christian Biesinger <cbiesinger@chromium.org>
> 
> Currently, gdb/main.c has to declare these two variables in the
> .c file. This patch adds the declarations to the header so that
> gdb can just use them.
> 
> gdbtk/ChangeLog:
> 
> 2019-10-07  Christian Biesinger  <cbiesinger@chromium.org>
> 
> 	* generic/gdbtk.h (gdbtk_test): Declare.
>   (external_editor_command): Declare.
>   (file): Prefix Tcl_Interp with "struct"
>   so that this compiles when Tcl headers aren't included.
>   * generic/gdbtk-interp.h:  Likewise.

That looks okay to me. Thank you for thinking of us!

Keith