From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9999 invoked by alias); 5 Apr 2012 12:48:03 -0000 Received: (qmail 9956 invoked by uid 22791); 5 Apr 2012 12:48:01 -0000 X-SWARE-Spam-Status: No, hits=1.9 required=5.0 tests=AWL,BAYES_50,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.datasphere.ch (HELO mail.datasphere.ch) (195.70.3.149) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 Apr 2012 12:47:47 +0000 Received: from dataspheresrv01.datasphere.ch ([195.70.3.151]) by mail.datasphere.ch (8.14.4/8.14.4) with ESMTP id q35ClfHl024672 for ; Thu, 5 Apr 2012 14:47:46 +0200 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----_=_NextPart_001_01CD132A.49AE8C53" Subject: [PATCH] fix error sending signal to dead process Date: Thu, 05 Apr 2012 12:48:00 -0000 Message-ID: From: "Patrick Monnerat" To: X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2012-q2/txt/msg00002.txt.bz2 This is a multi-part message in MIME format. ------_=_NextPart_001_01CD132A.49AE8C53 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Content-length: 675 =20 Using insight-7.4.50 (cvs snapshot 20120403), continuing or stepping after a fault (i.e. segfault) occurred results in sending a signal to the dead process. This is due to hook gdbtk_annotate_signal() trying to get thread_info structure with a null pid. Continuing in the same insight session (by re-running the program) finally ends in insight segfaulting. =20 The attached patch fixes this problem. It simply do not pass signal to tcl if the pid is null. =20 Cheers, Patrick =20 P.S.: the bug report system linked from your web site (http://sources.redhat.com/cgi-bin/gnatsweb.pl?database=3Dinsight&user=3Dgue st&password=3Dguest&cmd=3Dlogin) is down (HTTP error 500). ------_=_NextPart_001_01CD132A.49AE8C53 Content-Type: application/octet-stream; name="insight-7.4.50-sig2dead.patch" Content-Transfer-Encoding: base64 Content-Description: insight-7.4.50-sig2dead.patch Content-Disposition: attachment; filename="insight-7.4.50-sig2dead.patch" Content-length: 1237 ZGlmZiAtTmF1ciBpbnNpZ2h0LTcuNC41MC5vcmlnL2dkYi9nZGJ0ay9nZW5l cmljL2dkYnRrLWhvb2tzLmMgaW5zaWdodC03LjQuNTAubmV3L2dkYi9nZGJ0 ay9nZW5lcmljL2dkYnRrLWhvb2tzLmMKLS0tIGluc2lnaHQtNy40LjUwLm9y aWcvZ2RiL2dkYnRrL2dlbmVyaWMvZ2RidGstaG9va3MuYwkyMDEyLTAzLTI4 IDE1OjA5OjEyLjAwMDAwMDAwMCArMDIwMAorKysgaW5zaWdodC03LjQuNTAu bmV3L2dkYi9nZGJ0ay9nZW5lcmljL2dkYnRrLWhvb2tzLmMJMjAxMi0wNC0w NSAxMjo0NDoyMC4yODQzMDY5OTIgKzAyMDAKQEAgLTgwNCw3ICs4MDQsNyBA QAogZ2RidGtfYW5ub3RhdGVfc2lnbmFsICh2b2lkKQogewogICBjaGFyICpi dWY7Ci0gIHN0cnVjdCB0aHJlYWRfaW5mbyAqdHAgPSBpbmZlcmlvcl90aHJl YWQgKCk7CisgIHN0cnVjdCB0aHJlYWRfaW5mbyAqdHA7CiAKICAgLyogSW5m b3JtIGd1aSB0aGF0IHRoZSB0YXJnZXQgaGFzIHN0b3BwZWQuIFRoaXMgaXMK ICAgICAgYSBuZWNlc3Nhcnkgc3RvcCBidXR0b24gZXZpbC4gV2UgZG9uJ3Qg d2FudCBzaWduYWwgbm90aWZpY2F0aW9uCkBAIC04MTIsNiArODEyLDExIEBA CiAgICAgIHRpbWVvdXQuICovCiAgIFRjbF9FdmFsIChnZGJ0a19pbnRlcnAs ICJnZGJ0a19zdG9wX2lkbGVfY2FsbGJhY2siKTsKIAorICBpZiAocHRpZF9l cXVhbChpbmZlcmlvcl9wdGlkLCBudWxsX3B0aWQpKQorICAgIHJldHVybjsK KworICB0cCA9IGluZmVyaW9yX3RocmVhZCAoKTsKKwogICBidWYgPSB4c3Ry cHJpbnRmICgiZ2RidGtfc2lnbmFsICVzIHslc30iLAogCSAgICAgdGFyZ2V0 X3NpZ25hbF90b19uYW1lICh0cC0+c3VzcGVuZC5zdG9wX3NpZ25hbCksCiAJ ICAgICB0YXJnZXRfc2lnbmFsX3RvX3N0cmluZyAodHAtPnN1c3BlbmQuc3Rv cF9zaWduYWwpKTsK ------_=_NextPart_001_01CD132A.49AE8C53--