From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22064 invoked by alias); 19 Apr 2012 15:19:43 -0000 Received: (qmail 22055 invoked by uid 22791); 19 Apr 2012 15:19:42 -0000 X-SWARE-Spam-Status: No, hits=-0.2 required=5.0 tests=AWL,BAYES_20,KHOP_THREADED,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.datasphere.ch (HELO mail.datasphere.ch) (195.70.3.149) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 Apr 2012 15:19:13 +0000 Received: from dataspheresrv01.datasphere.ch ([195.70.3.151]) by mail.datasphere.ch (8.14.4/8.14.4) with ESMTP id q3JFJ2HM007377; Thu, 19 Apr 2012 17:19:07 +0200 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----_=_NextPart_001_01CD1E3F.C07E92D8" Subject: RE: [PATCH] fix error sending signal to dead process Date: Thu, 19 Apr 2012 15:19:00 -0000 Message-ID: In-Reply-To: <4F8F5AAD.9050207@redhat.com> References: <4F8F5AAD.9050207@redhat.com> From: "Patrick Monnerat" To: "Keith Seitz" Cc: X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2012-q2/txt/msg00021.txt.bz2 This is a multi-part message in MIME format. ------_=_NextPart_001_01CD1E3F.C07E92D8 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Content-length: 655 Keith Seitz wrote: > There should be spaces between function names and opening parenthesis. > [Yeah, it's rather lame, but it is GNU coding standard. Insight follows GDB's conventions.] > ChangeLog entry? The new attached patch fixes both of your remarks. It has been made against today's cvs snapshot. > [Aside: Eew. I can't believe Tcl_Eval is still being used!] Well... I'm not enough involved in insight's guts and tcl to share your estonishment. You're probably right. But I can say at least this call is clear enough to understand what's happening :-) In fact I'm only the insight's packager for Fedora. Thanks for your help. Cheers, Patrick ------_=_NextPart_001_01CD1E3F.C07E92D8 Content-Type: application/octet-stream; name="insight-7.4.50-sig2dead.patch" Content-Transfer-Encoding: base64 Content-Description: insight-7.4.50-sig2dead.patch Content-Disposition: attachment; filename="insight-7.4.50-sig2dead.patch" Content-length: 1847 ZGlmZiAtTmF1ciBzcmMub3JpZy9nZGIvZ2RidGsvQ2hhbmdlTG9nIHNyYy5u ZXcvZ2RiL2dkYnRrL0NoYW5nZUxvZwotLS0gc3JjLm9yaWcvZ2RiL2dkYnRr L0NoYW5nZUxvZwkyMDEyLTA0LTE5IDExOjQxOjI0LjAwMDAwMDAwMCArMDIw MAorKysgc3JjLm5ldy9nZGIvZ2RidGsvQ2hhbmdlTG9nCTIwMTItMDQtMTkg MTc6MDQ6MDQuNjAxNDYyNDAxICswMjAwCkBAIC0xLDMgKzEsOCBAQAorMjAx Mi0wNC0xOSAgUGF0cmljayBNb25uZXJhdCAgPHBtQGRhdGFzcGhlcmUuY2g+ CisKKwkqIGdlbmVyaWMvZ2RidGstaG9va3MuYyAoZ2RidGtfYW5ub3RhdGVf c2lnbmFsKTogQXZvaWQKKwlkZXJlZmVyZW5jaW5nIGEgbnVsbCAoaS5lLjog ZGVhZCkgcHJvY2Vzcy90aHJlYWQuCisKIDIwMTItMDQtMTkgIFJvbGFuZCBT Y2h3aW5nZWwgIDxyb2xhbmQuc2Nod2luZ2VsQG9uZXZpc2lvbi5jb20+CiAK IAkqIGdlbmVyaWMvZ2RidGstYnAuYzogVXBkYXRlZCBjb3B5cmlnaHQuCmRp ZmYgLU5hdXIgc3JjLm9yaWcvZ2RiL2dkYnRrL2dlbmVyaWMvZ2RidGstaG9v a3MuYyBzcmMubmV3L2dkYi9nZGJ0ay9nZW5lcmljL2dkYnRrLWhvb2tzLmMK LS0tIHNyYy5vcmlnL2dkYi9nZGJ0ay9nZW5lcmljL2dkYnRrLWhvb2tzLmMJ MjAxMi0wMy0yOCAxNTowOToxMi4wMDAwMDAwMDAgKzAyMDAKKysrIHNyYy5u ZXcvZ2RiL2dkYnRrL2dlbmVyaWMvZ2RidGstaG9va3MuYwkyMDEyLTA0LTE5 IDE2OjU3OjI3LjkyOTg4NDczMCArMDIwMApAQCAtODA0LDcgKzgwNCw3IEBA CiBnZGJ0a19hbm5vdGF0ZV9zaWduYWwgKHZvaWQpCiB7CiAgIGNoYXIgKmJ1 ZjsKLSAgc3RydWN0IHRocmVhZF9pbmZvICp0cCA9IGluZmVyaW9yX3RocmVh ZCAoKTsKKyAgc3RydWN0IHRocmVhZF9pbmZvICp0cDsKIAogICAvKiBJbmZv cm0gZ3VpIHRoYXQgdGhlIHRhcmdldCBoYXMgc3RvcHBlZC4gVGhpcyBpcwog ICAgICBhIG5lY2Vzc2FyeSBzdG9wIGJ1dHRvbiBldmlsLiBXZSBkb24ndCB3 YW50IHNpZ25hbCBub3RpZmljYXRpb24KQEAgLTgxMiw2ICs4MTIsMTEgQEAK ICAgICAgdGltZW91dC4gKi8KICAgVGNsX0V2YWwgKGdkYnRrX2ludGVycCwg ImdkYnRrX3N0b3BfaWRsZV9jYWxsYmFjayIpOwogCisgIGlmIChwdGlkX2Vx dWFsIChpbmZlcmlvcl9wdGlkLCBudWxsX3B0aWQpKQorICAgIHJldHVybjsK KworICB0cCA9IGluZmVyaW9yX3RocmVhZCAoKTsKKwogICBidWYgPSB4c3Ry cHJpbnRmICgiZ2RidGtfc2lnbmFsICVzIHslc30iLAogCSAgICAgdGFyZ2V0 X3NpZ25hbF90b19uYW1lICh0cC0+c3VzcGVuZC5zdG9wX3NpZ25hbCksCiAJ ICAgICB0YXJnZXRfc2lnbmFsX3RvX3N0cmluZyAodHAtPnN1c3BlbmQuc3Rv cF9zaWduYWwpKTsK ------_=_NextPart_001_01CD1E3F.C07E92D8--