From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <insight-return-6885-listarch-insight=sources.redhat.com@sourceware.org>
Received: (qmail 5403 invoked by alias); 14 May 2011 03:42:40 -0000
Received: (qmail 5394 invoked by uid 22791); 14 May 2011 03:42:39 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST
X-Spam-Check-By: sourceware.org
Received: from mail-fx0-f41.google.com (HELO mail-fx0-f41.google.com) (209.85.161.41)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 14 May 2011 03:42:25 +0000
Received: by fxm18 with SMTP id 18so2668540fxm.0        for <insight@sourceware.org>; Fri, 13 May 2011 20:42:24 -0700 (PDT)
Received: by 10.223.87.215 with SMTP id x23mr515755fal.32.1305344544082; Fri, 13 May 2011 20:42:24 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.223.105.74 with HTTP; Fri, 13 May 2011 20:42:04 -0700 (PDT)
In-Reply-To: <4DCC7D3A.5060206@redhat.com>
References: <BANLkTimo3Lb28=mT5FTy-mP1G80Q2mTjWw@mail.gmail.com> <4DCC7D3A.5060206@redhat.com>
From: Hui Zhu <teawater@gmail.com>
Date: Sat, 14 May 2011 03:42:00 -0000
Message-ID: <BANLkTi=eLRngtWP-xMbLzxVrOWbH5XLKyQ@mail.gmail.com>
Subject: Re: [BUG] build trunk error
To: Keith Seitz <keiths@redhat.com>
Cc: insight <insight@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact insight-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <insight.sourceware.org>
List-Subscribe: <mailto:insight-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/insight/>
List-Post: <mailto:insight@sourceware.org>
List-Help: <mailto:insight-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: insight-owner@sourceware.org
X-SW-Source: 2011-q2/txt/msg00012.txt.bz2

Thanks Keith.  My part is OK.

Best,
Hui

On Fri, May 13, 2011 at 08:37, Keith Seitz <keiths@redhat.com> wrote:
> On 05/08/2011 09:05 PM, Hui Zhu wrote:
>>
>> ../../src/gdb/gdbtk/generic/gdbtk-hooks.c: In function 'gdbtk_add_hooks':
>> ../../src/gdb/gdbtk/generic/gdbtk-hooks.c:126: error: passing argument
>> 1 of 'observer_attach_breakpoint_created' from incompatible pointer
>> type
>
> [snip]
>
> I've committed the attached patch to address this. IMO this patch should
> have been necessary years ago! [Better late than never, gdb! :-)]
>
> Thank you for notifying me.
>
> Keith
>
> ChangeLog
> 2011-05-12 =A0Keith Seitz =A0<keiths@redhat.com>
>
> =A0 =A0 =A0 =A0* generic/gdbtk-hooks.c (gdbtk_create_breakpoint): Change
> =A0 =A0 =A0 =A0parameter from `int' to `struct breakpoint *'.
> =A0 =A0 =A0 =A0(gdbtk_delete_breakpoint): Likewise.
> =A0 =A0 =A0 =A0(gdbtk_modify_breakpoint): Likewise.
> =A0 =A0 =A0 =A0* generic/gdbtk-bp.c (ALL_BREAKPOINTS): Define.
> =A0 =A0 =A0 =A0(breakpoint_list): Remove.
> =A0 =A0 =A0 =A0(breakpoint_list_size): Remove.
> =A0 =A0 =A0 =A0(Gdbtk_Breakpoint_Init): Remove initialization of breakpoi=
nt_list.
> =A0 =A0 =A0 =A0(gdb_find_bp_at_addr): Rewrite using ALL_BREAKPOINTS.
> =A0 =A0 =A0 =A0(gdb_find_bp_at_line): Likewise.
> =A0 =A0 =A0 =A0(gdb_get_breakpoint_info): Likewise.
> =A0 =A0 =A0 =A0(gdb_get_breakpoint_list): Likewise.
> =A0 =A0 =A0 =A0(gdbtk_create_breakpoint): Change parameter from `int' to
> =A0 =A0 =A0 =A0`struct breakpoint *' and update function.
> =A0 =A0 =A0 =A0(gdbtk_delete_breakpoint): Likewise.
> =A0 =A0 =A0 =A0(gdbtk_modify_breakpoint): Likewise.
> =A0 =A0 =A0 =A0(breakpoint_notify): Rewrite using ALL_BREAKPOINTS.
>