From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14464 invoked by alias); 11 Aug 2011 10:31:17 -0000 Received: (qmail 14456 invoked by uid 22791); 11 Aug 2011 10:31:16 -0000 X-SWARE-Spam-Status: No, hits=0.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 11 Aug 2011 10:31:02 +0000 Received: by vxj15 with SMTP id 15so1903550vxj.0 for ; Thu, 11 Aug 2011 03:31:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.174.105 with SMTP id br9mr238203vdc.207.1313058661825; Thu, 11 Aug 2011 03:31:01 -0700 (PDT) Received: by 10.52.115.233 with HTTP; Thu, 11 Aug 2011 03:31:01 -0700 (PDT) In-Reply-To: <4E3846CB.5020900@redhat.com> References: <4E372454.7010204@redhat.com> <4E3846CB.5020900@redhat.com> Date: Thu, 11 Aug 2011 10:31:00 -0000 Message-ID: Subject: Re: [PATCH] Recent GDB prompt/bp API updates From: Dave Murphy To: Keith Seitz Cc: insight@sourceware.org Content-Type: multipart/mixed; boundary=bcaec51b146d1b7b5c04aa384bf6 X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2011-q3/txt/msg00010.txt.bz2 --bcaec51b146d1b7b5c04aa384bf6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1346 On Tue, Aug 2, 2011 at 7:49 PM, Keith Seitz wrote: > On 08/01/2011 03:10 PM, Keith Seitz wrote: >> >> If there are any problems, please let me know. > > There was a problem: breakpoints could not be set through the Source Wind= ow. > I have committed the attach patch to correct this. > =A0 =A0 =A0 =A0* generic/gdbtk-bp.c (gdb_set_bp): Pass a valid breakpoint= _ops > =A0 =A0 =A0 =A0to create_breakpoint. I see this change in CVS but a build of insight under msys/mingw still can't seem to set breakpoints from the source window - this is for an arm-eabi target if it makes any difference. Setting a breakpoint from the console shows the red box in the source window and it can be disabled from there just fine. Also, oddly, some patching is needed to build with mingw/msys again which I could have sworn was fixed some time ago. The patch is pretty minor though. There's also a patch to config/tcl.m4 needed as well which needs gdb/configure & gdb/gdbtk/plugins/configure regenerated - does that belong to Insight or gdb? I've attached it here too. 2011-08-11 Dave Murphy * libgui/configure.ac: add mingw to win32 hosts * libgui/configure: regenerate * tcl/win/tclWinChan.c mark ESP/EBP as used * tcl/win/tclWinDde.c (Tcl_DdeObjCmd): remove invalid lvalue cast --bcaec51b146d1b7b5c04aa384bf6 Content-Type: application/octet-stream; name="insight-mingw.patch" Content-Disposition: attachment; filename="insight-mingw.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gr7kh6xz0 Content-length: 2603 SW5kZXg6IGxpYmd1aS9jb25maWd1cmUuYWMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2xpYmd1aS9jb25maWd1cmUu YWMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNApkaWZmIC11IC1yMS40IGNv bmZpZ3VyZS5hYwotLS0gbGliZ3VpL2NvbmZpZ3VyZS5hYwkyIEF1ZyAyMDA4 IDIzOjMzOjM2IC0wMDAwCTEuNAorKysgbGliZ3VpL2NvbmZpZ3VyZS5hYwkx MSBBdWcgMjAxMSAwOToyMTo1OCAtMDAwMApAQCAtNTMsNyArNTMsNyBAQAog ZmkKIAogY2FzZSAiJHtob3N0fSIgaW4KLSotKi1jeWd3aW4qKQorKi0qLWN5 Z3dpbip8Ki0qLW1pbmd3KikKICAgICAgICAgdG91Y2ggYWMkJC5jCiAgICAg ICAgIGlmICR7Q0N9IC1jIC1td2luMzIgYWMkJC5jID4vZGV2L251bGwgMj4m MTsgdGhlbgogICAgICAgICAgICAgY2FzZSAiJExJQkdVSV9DRkxBR1MiIGlu CkBAIC02NSw3ICs2NSw3IEBACiAgICAgICAgIDs7CiBlc2FjCiBjYXNlICIk e2hvc3R9IiBpbgotKi0qLWN5Z3dpbiopCisqLSotY3lnd2luKnwqLSotbWlu Z3cqKQogCUxJQkdVSV9DRkxBR1M9Ii1EV0lOMzIgJExJQkdVSV9DRkxBR1Mi IDs7CiBlc2FjCiBBQ19TVUJTVChMSUJHVUlfQ0ZMQUdTKSAKQEAgLTkzLDcg KzkzLDcgQEAKIGlmIHRlc3QgIiR7VENMX1NSQ19ESVJ9IiA9ICIke3RvcGRp cn0vdGNsIjsgdGhlbgogICAjIFVzaW5nIGluLXRyZWUgVGNsL1RrCiAgIGNh c2UgIiR7aG9zdH0iIGluCi0gICAgKi0qLWN5Z3dpbiopIHBsYXREaXI9Indp biIgOzsKKyAgICAqLSotY3lnd2luKnwqLSotbWluZ3cqKSBwbGF0RGlyPSJ3 aW4iIDs7CiAgICAgKikgcGxhdERpcj0idW5peCIgOzsKICAgZXNhYwogCklu ZGV4OiB0Y2wvd2luL3RjbFdpbkNoYW4uYwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvdGNsL3dpbi90Y2xXaW5DaGFu LmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNgpkaWZmIC11IC1yMS42IHRj bFdpbkNoYW4uYwotLS0gdGNsL3dpbi90Y2xXaW5DaGFuLmMJMiBGZWIgMjAw NiAyMDowMjowOSAtMDAwMAkxLjYKKysrIHRjbC93aW4vdGNsV2luQ2hhbi5j CTExIEF1ZyAyMDExIDA5OjIyOjA2IC0wMDAwCkBAIC0xMjIsOCArMTIyLDgg QEAKIH07CiAKICNpZmRlZiBIQVZFX05PX1NFSAotc3RhdGljIHZvaWQgKkVT UDsKLXN0YXRpYyB2b2lkICpFQlA7CitzdGF0aWMgdm9pZCAqRVNQIF9fYXR0 cmlidXRlX18oKHVzZWQpKTsKK3N0YXRpYyB2b2lkICpFQlAgX19hdHRyaWJ1 dGVfXygodXNlZCkpOwogI2VuZGlmIC8qIEhBVkVfTk9fU0VIICovCiAKIAwK SW5kZXg6IHRjbC93aW4vdGNsV2luRGRlLmMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL3RjbC93aW4vdGNsV2luRGRl LmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNQpkaWZmIC11IC1yMS41IHRj bFdpbkRkZS5jCi0tLSB0Y2wvd2luL3RjbFdpbkRkZS5jCTIxIEphbiAyMDAz IDE5OjQwOjIyIC0wMDAwCTEuNQorKysgdGNsL3dpbi90Y2xXaW5EZGUuYwkx MSBBdWcgMjAxMSAwOToyMjowNiAtMDAwMApAQCAtMTE3NSw3ICsxMTc1LDcg QEAKIAl9CiAJY2FzZSBEREVfRVZBTDogewogCSAgICBvYmpjIC09IChhc3lu YyArIDMpOwotCSAgICAoKFRjbF9PYmogKiopIG9ianYpICs9IChhc3luYyAr IDMpOworICAgICAgICBvYmp2ICs9IChhc3luYyArIDMpOwogCiAgICAgICAg ICAgICAvKgogCSAgICAgKiBTZWUgaWYgdGhlIHRhcmdldCBpbnRlcnByZXRl ciBpcyBsb2NhbC4gIElmIHNvLCBleGVjdXRlCg== --bcaec51b146d1b7b5c04aa384bf6 Content-Type: application/octet-stream; name="tcl.m4.patch" Content-Disposition: attachment; filename="tcl.m4.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gr7l6vhp1 Content-length: 1054 SW5kZXg6IGNvbmZpZy90Y2wubTQKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpS Q1MgZmlsZTogL2N2cy9zcmMvc3JjL2NvbmZpZy90Y2wubTQsdgpyZXRyaWV2 aW5nIHJldmlzaW9uIDEuMwpkaWZmIC11IC1yMS4zIHRjbC5tNAotLS0gY29u ZmlnL3RjbC5tNAkyIEZlYiAyMDA5IDIzOjE4OjA1IC0wMDAwCTEuMworKysg Y29uZmlnL3RjbC5tNAkxMSBBdWcgMjAxMSAxMDoyNDoyOSAtMDAwMApAQCAt MzMsNyArMzMsNyBAQAogCiAJICAgICMgRmlyc3QgY2hlY2sgdG8gc2VlIGlm IC0td2l0aC10Y2wgd2FzIHNwZWNpZmllZC4KIAkgICAgY2FzZSAiJHtob3N0 fSIgaW4KLQkJKi0qLWN5Z3dpbiopIHBsYXREaXI9IndpbiIgOzsKKwkJKi0q LWN5Z3dpbip8Ki0qLW1pbmd3KikgcGxhdERpcj0id2luIiA7OwogCQkqKSBw bGF0RGlyPSJ1bml4IiA7OwogCSAgICBlc2FjCiAJICAgIGlmIHRlc3QgeCIk e3dpdGhfdGNsY29uZmlnfSIgIT0geCA7IHRoZW4KQEAgLTE2NSw3ICsxNjUs NyBAQAogCiAJICAgICMgdGhlbiBjaGVjayBmb3IgYSBwcml2YXRlIFRrIGxp YnJhcnkKIAkgICAgY2FzZSAiJHtob3N0fSIgaW4KLQkJKi0qLWN5Z3dpbiop IHBsYXREaXI9IndpbiIgOzsKKwkJKi0qLWN5Z3dpbip8Ki0qLW1pbmd3Kikg cGxhdERpcj0id2luIiA7OwogCQkqKSBwbGF0RGlyPSJ1bml4IiA7OwogCSAg ICBlc2FjCiAJICAgIGlmIHRlc3QgeCIke2FjX2N2X2NfdGtjb25maWd9IiA9 IHggOyB0aGVuCg== --bcaec51b146d1b7b5c04aa384bf6--