Hi,

According to the discussion in
http://sourceware.org/ml/gdb/2012-08/msg00001.html

I post a new patch for GDB to change the arguments of
create_breakpoint to a struct.
And I also add a function create_breakpoint to Initialize all the
element of this struct to its default value.  Then if we want to add
more argument to this function, we can just add the default value
Initialize code to this function and don't need update all the
function that call create_breakpoint.

And I post a patch for insight to change the arguments of
create_breakpoint to a struct.

Please help me review it.

Thanks,
Hui

2013-02-21  Hui Zhu  <hui_zhu@mentor.com>

	* breakpoint.c (create_breakpoint_init): New function.
	(create_breakpoint): Change arguments to cb.
	(break_command_1): Call function create_breakpoint_init.
	Change arguments of create_breakpoint to cb.
	(dprintf_command): Ditto.
	(handle_gnu_v3_exceptions): Ditto.
	(trace_command): Ditto.
	(ftrace_command): Ditto.
	(strace_command): Ditto.
	(create_tracepoint_from_upload): Ditto.
	* breakpoint.h (create_breakpoint_s): New struct.
	(create_breakpoint_init): New extern.
	(create_breakpoint): Change arguments to cb.
	* mi/mi-cmd-break.c (mi_cmd_break_insert): Call function
	create_breakpoint_init.
	Change arguments of create_breakpoint to cb.
	* python/py-breakpoint.c (bppy_init): Ditto.
	* python/py-finishbreakpoint.c (bpfinishpy_init): Ditto.
	* spu-tdep.c (spu_catch_start): Ditto.

2013-02-21  Hui Zhu  <hui_zhu@mentor.com>

	* generic/gdbtk-bp.c (gdb_set_bp): Call function
	create_breakpoint_init.
	Change arguments of create_breakpoint to cb.