From: "Christian Biesinger via insight" <insight@sourceware.org>
To: Keith Seitz <keiths@redhat.com>
Cc: insight@sourceware.org
Subject: Re: [PATCH] Add declarations to gdbtk.h
Date: Thu, 10 Oct 2019 00:35:00 -0000 [thread overview]
Message-ID: <CAPTJ0XF=GeUkHwXWBVHmVyo1h+2BP5L3eWX8LMUx8j=t2V4TTg@mail.gmail.com> (raw)
In-Reply-To: <9d348976-d7bc-3ff3-9e68-026cbb997194@redhat.com>
Great thanks! Could you check this in? I don't think I have commit access
to this repository.
Christian
On Wed, Oct 9, 2019, 19:20 Keith Seitz <keiths@redhat.com> wrote:
> On 10/7/19 2:09 PM, Christian Biesinger via insight wrote:
> > From: Christian Biesinger <cbiesinger@chromium.org>
> >
> > Currently, gdb/main.c has to declare these two variables in the
> > .c file. This patch adds the declarations to the header so that
> > gdb can just use them.
> >
> > gdbtk/ChangeLog:
> >
> > 2019-10-07 Christian Biesinger <cbiesinger@chromium.org>
> >
> > * generic/gdbtk.h (gdbtk_test): Declare.
> > (external_editor_command): Declare.
> > (file): Prefix Tcl_Interp with "struct"
> > so that this compiles when Tcl headers aren't included.
> > * generic/gdbtk-interp.h: Likewise.
>
> That looks okay to me. Thank you for thinking of us!
>
> Keith
>
next prev parent reply other threads:[~2019-10-10 0:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 21:09 Christian Biesinger via insight
2019-10-07 22:40 ` Mike Wellington
2019-10-07 22:43 ` Christian Biesinger via insight
2019-10-07 22:48 ` Mike Wellington
2019-10-10 0:20 ` Keith Seitz
2019-10-10 0:35 ` Christian Biesinger via insight [this message]
2019-10-10 15:55 ` Keith Seitz
2019-10-10 17:47 ` Christian Biesinger via insight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPTJ0XF=GeUkHwXWBVHmVyo1h+2BP5L3eWX8LMUx8j=t2V4TTg@mail.gmail.com' \
--to=insight@sourceware.org \
--cc=cbiesinger@google.com \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).