From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117406 invoked by alias); 10 Oct 2019 00:35:33 -0000 Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org Received: (qmail 117398 invoked by uid 89); 10 Oct 2019 00:35:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.9 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=H*c:alternative, us!, us X-HELO: mail-ot1-f52.google.com Received: from mail-ot1-f52.google.com (HELO mail-ot1-f52.google.com) (209.85.210.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Oct 2019 00:35:31 +0000 Received: by mail-ot1-f52.google.com with SMTP id 21so3338346otj.11 for ; Wed, 09 Oct 2019 17:35:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YmtQP6ojygbar4jlZzrOpQhE2olbq9lSan6wFCyDXrI=; b=gCK2F9vqD6hX4LteFDNDtbWwi97Rb5JB+f4wt1whu0kc/VhpBv0x3Q0f6E8aBAevvr LAWqQjDY3RcKAp9M8JW/EiKHwZoX6Vn02jaUTEOV9YAA1sy0qtFvsPgNoBaB2MIKHd1X TMvj+XrmpTS9D2hE6y3YLa5O38ljHe49y0rtyYCvQhsInl3+uZ/UaWXYZmgVl9DHKsJw paKB82JPvjH1NAcCnhF3bjobU+oBZfHHSTzdS7qjjaY4I/JqsdheLGoyKe8XvynlPMtp 95mv1hVZQyJXUSLT1aG11HfwIILvpgoDvsSPe0VVH0qKTMl0Np2aF68ZWqK5BXtXLDSf 7PbQ== MIME-Version: 1.0 References: <20191007210928.239798-1-cbiesinger@google.com> <9d348976-d7bc-3ff3-9e68-026cbb997194@redhat.com> In-Reply-To: <9d348976-d7bc-3ff3-9e68-026cbb997194@redhat.com> From: "Christian Biesinger via insight" Reply-To: Christian Biesinger Date: Thu, 10 Oct 2019 00:35:00 -0000 Message-ID: Subject: Re: [PATCH] Add declarations to gdbtk.h To: Keith Seitz Cc: insight@sourceware.org Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2019-q4/txt/msg00005.txt.bz2 Great thanks! Could you check this in? I don't think I have commit access to this repository. Christian On Wed, Oct 9, 2019, 19:20 Keith Seitz wrote: > On 10/7/19 2:09 PM, Christian Biesinger via insight wrote: > > From: Christian Biesinger > > > > Currently, gdb/main.c has to declare these two variables in the > > .c file. This patch adds the declarations to the header so that > > gdb can just use them. > > > > gdbtk/ChangeLog: > > > > 2019-10-07 Christian Biesinger > > > > * generic/gdbtk.h (gdbtk_test): Declare. > > (external_editor_command): Declare. > > (file): Prefix Tcl_Interp with "struct" > > so that this compiles when Tcl headers aren't included. > > * generic/gdbtk-interp.h: Likewise. > > That looks okay to me. Thank you for thinking of us! > > Keith >