From: Keith Seitz <keiths@cygnus.com>
To: Mo DeJong <mdejong@cygnus.com>
Cc: <insight@sources.redhat.com>
Subject: Re: PATCH: Avoid compiler warning in src/tclhelp.c
Date: Fri, 03 Aug 2001 16:28:00 -0000 [thread overview]
Message-ID: <Pine.GSO.4.33.0108031627500.13943-100000@makita.cygnus.com> (raw)
In-Reply-To: <Pine.SOL.3.91.1010803162353.23102N@cse.cygnus.com>
On Fri, 3 Aug 2001, Mo DeJong wrote:
> Here is a patch to avoid a compiler warning in src/tclhelp.c:
>
> The compiler warning:
> ...
> ../../../devo/libgui/src/tclhelp.c
> ../../../devo/libgui/src/tclhelp.c: In function `help_display_file_command':
> ../../../devo/libgui/src/tclhelp.c:327: warning: passing arg 3 of
> `Tcl_GetInt'
> from incompatible pointer type
Yes, please check this in.
Thanks,
Keith
> 2001-08-03 Mo DeJong <mdejong@redhat.com>
>
> * src/tclhelp.c (help_display_file_command): Pass int
> address to Tcl_GetInt instead of an unsigned long to
> avoid compiler warning.
>
> Index: src/tclhelp.c
> ===================================================================
> RCS file: /cvs/cvsfiles/devo/libgui/src/tclhelp.c,v
> retrieving revision 1.6.212.3
> diff -u -r1.6.212.3 tclhelp.c
> --- tclhelp.c 2001/08/03 23:06:13 1.6.212.3
> +++ tclhelp.c 2001/08/03 23:19:24
> @@ -303,7 +303,8 @@
> {
> struct help_command_data *hdata = (struct help_command_data *) cd;
> FILE *e;
> - DWORD topic_id = 0; /* default topic id is 0 which brings up the find dialog */
> + int id = 0;
> + DWORD topic_id; /* default topic id is 0 which brings up the find dialog */
>
> /* We call Help initialize just to make sure the window handle is
> setup */
> /* We don't care about the finding the main help file and checking the */
> @@ -324,10 +325,11 @@
> fclose (e);
> if (argc > 3)
> {
> - if ( Tcl_GetInt (interp, argv[3], &topic_id) != TCL_OK )
> + if ( Tcl_GetInt (interp, argv[3], &id) != TCL_OK )
> return TCL_ERROR;
> }
>
> + topic_id = (DWORD) id;
> if (! WinHelp (hdata->window, argv[2], HELP_CONTEXT, topic_id))
> {
> char buf[200];
>
>
> cheers
> Mo
>
next prev parent reply other threads:[~2001-08-03 16:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-03 16:12 PATCH: Support TCL_MEM_DEBUG in libgui Mo DeJong
2001-08-03 16:25 ` PATCH: Avoid compiler warning in src/tclhelp.c Mo DeJong
2001-08-03 16:28 ` Keith Seitz [this message]
2001-08-03 16:33 ` PATCH: Support TCL_MEM_DEBUG in libgui Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.33.0108031627500.13943-100000@makita.cygnus.com \
--to=keiths@cygnus.com \
--cc=insight@sources.redhat.com \
--cc=mdejong@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).