From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keith Seitz <keiths@cygnus.com>
To: Mo DeJong <mdejong@cygnus.com>
Cc: <insight@sources.redhat.com>
Subject: Re: PATCH: Avoid compiler warning in src/tclhelp.c
Date: Fri, 03 Aug 2001 16:28:00 -0000
Message-id: <Pine.GSO.4.33.0108031627500.13943-100000@makita.cygnus.com>
References: <Pine.SOL.3.91.1010803162353.23102N@cse.cygnus.com>
X-SW-Source: 2001-q3/msg00083.html

On Fri, 3 Aug 2001, Mo DeJong wrote:

> Here is a patch to avoid a compiler warning in src/tclhelp.c:
>
> The compiler warning:
> ...
>  ../../../devo/libgui/src/tclhelp.c
> ../../../devo/libgui/src/tclhelp.c: In function `help_display_file_command':
> ../../../devo/libgui/src/tclhelp.c:327: warning: passing arg 3 of
> `Tcl_GetInt'
> from incompatible pointer type

Yes, please check this in.

Thanks,
Keith


> 2001-08-03  Mo DeJong  <mdejong@redhat.com>
>
> 	* src/tclhelp.c (help_display_file_command): Pass int
> 	address to Tcl_GetInt instead of an unsigned long to
> 	avoid compiler warning.
>
> Index: src/tclhelp.c
> ===================================================================
> RCS file: /cvs/cvsfiles/devo/libgui/src/tclhelp.c,v
> retrieving revision 1.6.212.3
> diff -u -r1.6.212.3 tclhelp.c
> --- tclhelp.c	2001/08/03 23:06:13	1.6.212.3
> +++ tclhelp.c	2001/08/03 23:19:24
> @@ -303,7 +303,8 @@
>  {
>    struct help_command_data *hdata = (struct help_command_data *) cd;
>    FILE *e;
> -  DWORD   topic_id = 0; /* default topic id is 0 which brings up the find dialog */
> +  int id = 0;
> +  DWORD   topic_id; /* default topic id is 0 which brings up the find dialog */
>
>    /* We call Help initialize just to make sure the window handle is
> setup */
>    /* We don't care about the finding the main help file and checking the */
> @@ -324,10 +325,11 @@
>    fclose (e);
>    if (argc > 3)
>    {
> -      if ( Tcl_GetInt (interp, argv[3], &topic_id) != TCL_OK )
> +      if ( Tcl_GetInt (interp, argv[3], &id) != TCL_OK )
>          return TCL_ERROR;
>    }
>
> +  topic_id = (DWORD) id;
>    if (! WinHelp (hdata->window, argv[2], HELP_CONTEXT, topic_id))
>    {
>        char buf[200];
>
>
> cheers
> Mo
>