From: Keith Seitz <keiths@cygnus.com>
To: Insight Maling List <insight@sources.redhat.com>
Cc: Ian Roxborough <irox@cygnus.com>
Subject: [PATCH] Tcl cleanups from Ian
Date: Thu, 16 Aug 2001 08:48:00 -0000 [thread overview]
Message-ID: <Pine.GSO.4.33.0108160847020.10383-100000@makita.cygnus.com> (raw)
Hi,
I've committed the following patch to the repository.
My thanks to Ian for looking into this nightmare.
Keith
ChangeLog
2001-08-16 Keith Seitz <keiths@redhat.com>
From Ian Roxborough <irox@redhat.com>
* generic/gdbtk-hooks.c (x_event): Deal with Tcl API insanity
for Tcl_ObjGetVar2 or Tcl_GetObjVar2.
(gdbtk_trace_find): Likewise for Tcl_GlobalEvalObj
or Tcl_EvalObj (TCL_EVAL_GLOBAL).
Patch
Index: generic/gdbtk-hooks.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-hooks.c,v
retrieving revision 1.17
diff -u -p -r1.17 gdbtk-hooks.c
--- gdbtk-hooks.c 2001/08/13 18:30:36 1.17
+++ gdbtk-hooks.c 2001/08/16 15:17:59
@@ -462,7 +462,7 @@ x_event (signo)
int val;
if (varname == NULL)
{
-#if TCL_MAJOR_VERSION == 8 && TCL_MINOR_VERSION < 1
+#if TCL_MAJOR_VERSION == 8 && (TCL_MINOR_VERSION < 1 || TCL_MINOR_VERSION > 2)
Tcl_Obj *varnamestrobj = Tcl_NewStringObj ("download_cancel_ok", -1);
varname = Tcl_ObjGetVar2 (gdbtk_interp, varnamestrobj, NULL, TCL_GLOBAL_ONLY);
#else
@@ -733,7 +733,7 @@ gdbtk_trace_find (arg, from_tty)
Tcl_NewStringObj ("gdbtk_tcl_trace_find_hook", -1));
Tcl_ListObjAppendElement (gdbtk_interp, cmdObj, Tcl_NewStringObj (arg, -1));
Tcl_ListObjAppendElement (gdbtk_interp, cmdObj, Tcl_NewIntObj (from_tty));
-#if TCL_MAJOR_VERSION == 8 && TCL_MINOR_VERSION < 1
+#if TCL_MAJOR_VERSION == 8 && (TCL_MINOR_VERSION < 1 || TCL_MINOR_VERSION > 2)
if (Tcl_GlobalEvalObj (gdbtk_interp, cmdObj) != TCL_OK)
report_error ();
#else
reply other threads:[~2001-08-16 8:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.33.0108160847020.10383-100000@makita.cygnus.com \
--to=keiths@cygnus.com \
--cc=insight@sources.redhat.com \
--cc=irox@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).