From: Keith Seitz <keiths@cygnus.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Insight List <insight@sourceware.cygnus.com>
Subject: Re: Patch: Fix .gdbtkinit reading
Date: Wed, 22 Aug 2001 11:38:00 -0000 [thread overview]
Message-ID: <Pine.GSO.4.33.0108221138080.22387-100000@makita.cygnus.com> (raw)
In-Reply-To: <87r8u5jc2u.fsf@creche.redhat.com>
On 21 Aug 2001, Tom Tromey wrote:
> Currently Insight tries to encode preference values which include `='.
> Unfortunately due to a small bug Insight doesn't properly re-read such
> values.
>
> I found this while trying to use a saved session. I tested the
> appended patch on that session. Ok to commit?
Looks pretty innocent to me. Did this fix your session problem, or do you
still need someone to look at it?
Keith
> Index: ChangeLog
> from Tom Tromey <tromey@redhat.com>
>
> * library/prefs.tcl (pref_read): Version number appears in
> comment.
>
> Index: library/prefs.tcl
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/prefs.tcl,v
> retrieving revision 1.11
> diff -u -r1.11 prefs.tcl
> --- library/prefs.tcl 2001/08/09 20:43:54 1.11
> +++ library/prefs.tcl 2001/08/21 21:39:37
> @@ -78,7 +78,8 @@
> {^[ \t\n]*#.*} {
> # Comment. We recognize one magic comment that includes
> # the version number.
> - if {[regexp -- "^GDBtkInitVersion: (\[0-9\]+)\$" $line v]} {
> + if {[regexp -- "^# GDBtkInitVersion: (\[0-9\]+)\$" $line \
> + dummy v]} {
> set version $v
> }
> }
>
next prev parent reply other threads:[~2001-08-22 11:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-21 14:39 Tom Tromey
2001-08-22 11:38 ` Keith Seitz [this message]
2001-08-22 11:43 ` Tom Tromey
2001-08-22 12:01 ` Keith Seitz
2001-08-22 14:11 ` Tom Tromey
2001-08-22 15:26 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.33.0108221138080.22387-100000@makita.cygnus.com \
--to=keiths@cygnus.com \
--cc=insight@sourceware.cygnus.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).