From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21483 invoked by alias); 7 Dec 2001 18:00:00 -0000 Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sources.redhat.com Received: (qmail 21403 invoked from network); 7 Dec 2001 17:59:55 -0000 X-Authentication-Warning: makita.cygnus.com: keiths owned process doing -bs Date: Wed, 10 Oct 2001 10:01:00 -0000 From: Keith Seitz To: Elena Zannoni cc: , , Insight Maling List Subject: Re: Patch ping In-Reply-To: <15376.60482.801783.728261@krustylu.cygnus.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2001-q4/txt/msg00101.txt.bz2 My bad... On Fri, 7 Dec 2001, Elena Zannoni wrote: > Tom Tromey writes: > > This patch has been unreviewed for a month: > > > > http://sources.redhat.com/ml/gdb-patches/2001-11/msg00108.html > > > > Tom > > Yes, I didn't forget. I was waiting for some comments on the insight > changes. I am cc-ing that list. I really don't know what to say. The only thing I know about this function is from its comment: /* The lookup_symtab() in symtab.c doesn't work correctly */ /* It will not work will full pathnames and if multiple */ /* source files have the same basename, it will return */ /* the first one instead of the correct one. */ /* symtab->fullname will be NULL if the file is not available. */ I've created a simple testcase which looks like this: $ ls * foo* foo.c a: foo.c b: foo.c c: foo.c So we have four filenames called foo.c. Now if I change full_lookup_symtab to skip what it does and ONLY call lookup_symtab, I cannot load any source file from Insight. It just doesn't find any. After applying this patch, everything seems to work again. So, yes, please do check it in. We'll worry about any fallout later. (Sorry for draggin' my *** so long on this.) Keith From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Seitz To: Elena Zannoni Cc: , , Insight Maling List Subject: Re: Patch ping Date: Fri, 07 Dec 2001 10:00:00 -0000 Message-ID: References: <15376.60482.801783.728261@krustylu.cygnus.com> X-SW-Source: 2001-q4/msg00402.html Message-ID: <20011207100000.wZOZcDu-xo0074M2Hy_GC6nF4GH2z7n8GYIOCyrrjD8@z> My bad... On Fri, 7 Dec 2001, Elena Zannoni wrote: > Tom Tromey writes: > > This patch has been unreviewed for a month: > > > > http://sources.redhat.com/ml/gdb-patches/2001-11/msg00108.html > > > > Tom > > Yes, I didn't forget. I was waiting for some comments on the insight > changes. I am cc-ing that list. I really don't know what to say. The only thing I know about this function is from its comment: /* The lookup_symtab() in symtab.c doesn't work correctly */ /* It will not work will full pathnames and if multiple */ /* source files have the same basename, it will return */ /* the first one instead of the correct one. */ /* symtab->fullname will be NULL if the file is not available. */ I've created a simple testcase which looks like this: $ ls * foo* foo.c a: foo.c b: foo.c c: foo.c So we have four filenames called foo.c. Now if I change full_lookup_symtab to skip what it does and ONLY call lookup_symtab, I cannot load any source file from Insight. It just doesn't find any. After applying this patch, everything seems to work again. So, yes, please do check it in. We'll worry about any fallout later. (Sorry for draggin' my *** so long on this.) Keith