From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <insight-return-3146-listarch-insight=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 11384 invoked by alias); 3 Jan 2002 01:55:06 -0000
Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:insight-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/insight/>
List-Post: <mailto:insight@sources.redhat.com>
List-Help: <mailto:insight-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: insight-owner@sources.redhat.com
Received: (qmail 11267 invoked from network); 3 Jan 2002 01:55:03 -0000
X-Authentication-Warning: makita.cygnus.com: keiths owned process doing -bs
Date: Wed, 02 Jan 2002 17:55:00 -0000
From: Keith Seitz <keiths@redhat.com>
X-X-Sender:  <keiths@makita.cygnus.com>
To: "Martin M. Hunt" <hunt@redhat.com>
cc: Insight Mailing List <insight@sources.redhat.com>
Subject: Re: [RFA] source window focus patch
In-Reply-To: <200201030113.RAA19126@cygnus.com>
Message-ID: <Pine.GSO.4.33.0201021753240.9746-100000@makita.cygnus.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2002-q1/txt/msg00008.txt.bz2

On Wed, 2 Jan 2002, Martin M. Hunt wrote:

> For the last 6 months, the console window has been almost useless due to
> the bug that Keith recently fixed, plus another nasty bug that keeps taking
> thefocus away from the console window and puts it on the source window.  This
> patch should fix that.

Ok, I know that this all stems from Nick Duffek's change on 2001-03-01,
and I think that this patch is worth a try. We'll have to watch for focus
loss inside the source window while stepping.

If anyone notices any focus problems with the source window, please let us
know.

Thanks, Martin.
Keith

>
> --
> Martin Hunt
> GDB Engineer
> Red Hat, Inc.
>
> 2002-01-02  Martin M. Hunt  <hunt@redhat.com>
>
> 	* library/srctextwin.itb: Set focus on srcwin only
> 	if another window doesn't have the focus.
>
> Index: srctextwin.itb
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/srctextwin.itb,v
> retrieving revision 1.28
> diff -u -p -r1.28 srctextwin.itb
> --- srctextwin.itb	2001/10/04 15:01:36	1.28
> +++ srctextwin.itb	2002/01/03 01:08:27
> @@ -681,8 +681,10 @@ body SrcTextWin::config_win {win {asm S}
>    bind_plain_key $win Up [list %W yview scroll -1 units]
>    bind_plain_key $win Down [list %W yview scroll +1 units]
>
> -  # Make key bindings usable immediately (without mouse click in window).
> -  focus $win
> +  # After loading a new file, focus sometimes gets lost
> +  # so point it back to this window if it doesn't already
> +  # point elsewhere.
> +  if {[focus -displayof $win] == ""} {focus $win}
>  }
>
>  # ------------------------------------------------------------------
>