From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <insight-return-3192-listarch-insight=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 7417 invoked by alias); 15 Jan 2002 19:18:42 -0000
Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:insight-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/insight/>
List-Post: <mailto:insight@sources.redhat.com>
List-Help: <mailto:insight-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: insight-owner@sources.redhat.com
Received: (qmail 7382 invoked from network); 15 Jan 2002 19:18:39 -0000
Received: from unknown (HELO cygnus.com) (205.180.230.5)
  by sources.redhat.com with SMTP; 15 Jan 2002 19:18:39 -0000
Received: from makita.cygnus.com (makita.sfbay.redhat.com [205.180.230.78])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id LAA03336
	for <insight@sources.redhat.com>; Tue, 15 Jan 2002 11:18:24 -0800 (PST)
Received: from localhost (keiths@localhost) by makita.cygnus.com (8.8.8+Sun/8.6.4) with ESMTP id LAA09848 for <insight@sources.redhat.com>; Tue, 15 Jan 2002 11:18:23 -0800 (PST)
X-Authentication-Warning: makita.cygnus.com: keiths owned process doing -bs
Date: Tue, 15 Jan 2002 11:18:00 -0000
From: Keith Seitz <keiths@redhat.com>
X-X-Sender:  <keiths@makita.cygnus.com>
To: Insight Maling List <insight@sources.redhat.com>
Subject: [PATCH] pass varobj errors
Message-ID: <Pine.GSO.4.33.0201151117080.17875-100000@makita.cygnus.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2002-q1/txt/msg00054.txt.bz2

Hi,

I seem to recall having posted this before, but just in case...

Keith

ChangeLog
2002-01-15  Keith Seitz  <keiths@redhat.com>

 	* generic/gdbtk-varobj.c (variable_value): When varobj_get_value
 	fails, use error_last_message to return the error to tcl land.
 	This allows us to display nice messages about why "0xdeadbeef" is
 	not accessible!

Index: generic/gdbtk-varobj.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-varobj.c,v
retrieving revision 1.10
diff -p -r1.10 gdbtk-varobj.c
*** gdbtk-varobj.c	2001/11/05 19:42:48	1.10
--- gdbtk-varobj.c	2002/01/15 19:13:29
*************** variable_value (interp, objc, objv, var)
*** 609,615 ****
    r = varobj_get_value (var);

    if (r == NULL)
!     return TCL_ERROR;
    else
      {
        Tcl_SetObjResult (interp, Tcl_NewStringObj (r, -1));
--- 609,620 ----
    r = varobj_get_value (var);

    if (r == NULL)
!     {
!       char *err = error_last_message ();
!       gdbtk_set_result (interp, "%s", err);
!       xfree (err);
!       return TCL_ERROR;
!     }
    else
      {
        Tcl_SetObjResult (interp, Tcl_NewStringObj (r, -1));