From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9418 invoked by alias); 5 Mar 2002 19:33:51 -0000 Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sources.redhat.com Received: (qmail 9366 invoked from network); 5 Mar 2002 19:33:50 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 5 Mar 2002 19:33:50 -0000 Received: from makita.cygnus.com (makita.cygnus.com [205.180.230.78]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id LAA25608; Tue, 5 Mar 2002 11:33:49 -0800 (PST) Received: from localhost (keiths@localhost) by makita.cygnus.com (8.8.8+Sun/8.6.4) with ESMTP id LAA17554; Tue, 5 Mar 2002 11:33:49 -0800 (PST) X-Authentication-Warning: makita.cygnus.com: keiths owned process doing -bs Date: Tue, 05 Mar 2002 11:33:00 -0000 From: Keith Seitz X-X-Sender: To: "Martin M. Hunt" cc: Insight Mailing List Subject: Re: [RFA] Remove src-font In-Reply-To: <200203030610.g236ALG02980@localhost.localdomain> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2002-q1/txt/msg00175.txt.bz2 On Sat, 2 Mar 2002, Martin M. Hunt wrote: > src-font is a prehistoric name for the font used by the source window. > It predates libgui and tcl8.0. Libgui creates a bunch of font objects for > us and tracks changes to preferences, so src-font long ago became > redundant. This patch replaces it with its equivalent, "global/fixed". Only one question... > Index: console.itb > =================================================================== > RCS file: /cvs/src/src/gdb/gdbtk/library/console.itb,v > retrieving revision 1.19 > diff -u -p -r1.19 console.itb > --- console.itb 2002/01/18 17:24:29 1.19 > +++ console.itb 2002/03/03 06:03:16 > @@ -20,18 +20,6 @@ body Console::constructor {args} { > _build_win > eval itk_initialize $args > add_hook gdb_no_inferior_hook [list $this idle dummy] > - > - # Right now the preferences window directly uses preference > - # variables. This means that if we track the preference changes > - # here, things will appear weird to the user -- the console window > - # will change before the user chooses Accpet in the prefs window. > - # Until the preference window is fixed we can't enable this > - # dynamic tracking. FIXME. > - # foreach option {gdb/console/wrap gdb/console/prompt_fg \ > - # gdb/console/error_fg gdb/console/font} { > - # pref add_hook $option [code $this _update_option] > - # } > - I'd like to update this comment and keep it in (along with the commented out Console::_update_option). I believe that you fixed the prefs window glitch, so now it is just a matter of re-doing the preferences so that we can either add preferences dynamically or we need to update the preferences to contain the options specified in this. I know I would certainly like to change a few of these (particularly the wrap one). Otherwise, please check this all in. Thanks. Keith