From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <insight-return-3329-listarch-insight=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 4612 invoked by alias); 7 Mar 2002 18:43:53 -0000
Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:insight-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/insight/>
List-Post: <mailto:insight@sources.redhat.com>
List-Help: <mailto:insight-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: insight-owner@sources.redhat.com
Received: (qmail 4542 invoked from network); 7 Mar 2002 18:43:50 -0000
Received: from unknown (HELO cygnus.com) (205.180.230.5)
  by sources.redhat.com with SMTP; 7 Mar 2002 18:43:50 -0000
Received: from makita.cygnus.com (makita.cygnus.com [205.180.230.78])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id KAA03463;
	Thu, 7 Mar 2002 10:43:49 -0800 (PST)
Received: from localhost (keiths@localhost) by makita.cygnus.com (8.8.8+Sun/8.6.4) with ESMTP id KAA05852; Thu, 7 Mar 2002 10:43:49 -0800 (PST)
X-Authentication-Warning: makita.cygnus.com: keiths owned process doing -bs
Date: Thu, 07 Mar 2002 10:43:00 -0000
From: Keith Seitz <keiths@redhat.com>
X-X-Sender:  <keiths@makita.cygnus.com>
To: "Martin M. Hunt" <hunt@redhat.com>
cc: Insight Mailing List <insight@sources.redhat.com>
Subject: Re: [RFA] breakpoint balloon info
In-Reply-To: <200203070828.g278SGx01719@localhost.localdomain>
Message-ID: <Pine.GSO.4.33.0203071042440.5360-100000@makita.cygnus.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2002-q1/txt/msg00191.txt.bz2

On Thu, 7 Mar 2002, Martin M. Hunt wrote:

> 2002-03-06  Martin M. Hunt  <hunt@redhat.com>
>
> 	* library/srctextwin.itb (SrcTextWin::showBPBalloon):
> 	Reformat output. Add conditions, ignore count, commands.

Don't we need to be a little careful about commands? They could be huge...

Anyway, it all looks innocent enough. Does any of this break the srcwin
tests, by chance? I know we test something about BP balloons in there.

Please commit. Thanks,
Keith


> Index: srctextwin.itb
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/srctextwin.itb,v
> retrieving revision 1.32
> diff -u -p -r1.32 srctextwin.itb
> --- srctextwin.itb	2002/03/05 22:22:20	1.32
> +++ srctextwin.itb	2002/03/07 08:25:09
> @@ -2310,27 +2310,36 @@ body SrcTextWin::showBPBalloon {win x y}
>    }
>
>    set str ""
> -  set need_lf 0
>    foreach b $bps {
>      set bpinfo [gdb_get_breakpoint_info $b]
>      lassign $bpinfo file func linenum addr type enabled disposition \
>        ignore_count commands cond thread hit_count user_specification
> -    if {$thread == "-1"} {set thread "all"}
>      set file [lindex [file split $file] end]
>      if {$enabled} {
>        set enabled "ENA"
>      } else {
>        set enabled "DIS"
>      }
> -    if {$cond == ""} {set cond "none"}
> -    if {$need_lf} {
> -      append str \n
> -    } else {
> -      set need_lf 1
> +
> +    append str [format "breakpoint %d at %s:%d (%#x)\n   %s %s %s" \
> +		  $b $file $linenum $addr $enabled $type $disposition]
> +
> +    if {$thread != "-1"} {
> +      append str "\n   threads: $thread"
> +    }
> +
> +    if {$ignore_count != 0} {
> +      append str "\n   ignore: $ignore_count"
> +    }
> +
> +    if {$cond != ""} {
> +      append str "\n   condition: $cond"
> +    }
> +
> +    if {$commands != ""} {
> +      append str "\n   commands: $commands"
>      }
> -    append str [format "breakpoint %d at %s:%d (%#x)\n\t%s %s %s %s %s" \
> -		  $b $file $linenum $addr $enabled $type $disposition \
> -		  threads=$thread cond=$cond]
> +
>    }
>
>    # Scope out which break type is set here, and use the tag to get
>