From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <insight-return-3379-listarch-insight=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 11598 invoked by alias); 1 Apr 2002 22:27:51 -0000
Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:insight-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/insight/>
List-Post: <mailto:insight@sources.redhat.com>
List-Help: <mailto:insight-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: insight-owner@sources.redhat.com
Received: (qmail 11589 invoked from network); 1 Apr 2002 22:27:48 -0000
Received: from unknown (HELO cygnus.com) (205.180.230.5)
  by sources.redhat.com with SMTP; 1 Apr 2002 22:27:48 -0000
Received: from makita.cygnus.com (makita.cygnus.com [205.180.230.78])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id OAA05526
	for <insight@sources.redhat.com>; Mon, 1 Apr 2002 14:27:48 -0800 (PST)
Received: from localhost (keiths@localhost) by makita.cygnus.com (8.8.8+Sun/8.6.4) with ESMTP id OAA21981 for <insight@sources.redhat.com>; Mon, 1 Apr 2002 14:27:47 -0800 (PST)
X-Authentication-Warning: makita.cygnus.com: keiths owned process doing -bs
Date: Mon, 01 Apr 2002 14:27:00 -0000
From: Keith Seitz <keiths@redhat.com>
X-X-Sender:  <keiths@makita.cygnus.com>
To: Insight Maling List <insight@sources.redhat.com>
Subject: [PATCH] Whack last calls to parse_and_eval_address
Message-ID: <Pine.GSO.4.33.0204011425470.20717-100000@makita.cygnus.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2002-q2/txt/msg00001.txt.bz2

Hi,

I think these were missed by earlier attempts to remove
parse_and_eval_address. I've also thrown in an obvious free->xfree fix.

Keith

ChangeLog
2002-04-01  Keith Seitz  <keiths@redhat.com>

        * generic/gdbtk-cmds.c (gdb_load_disassembly): Use string_to_core_addr
        instead of parse_and_eval_address.
	Use xfree instead of free.

Patch
Index: generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.54
diff -p -r1.54 gdbtk-cmds.c
*** generic/gdbtk-cmds.c	2002/03/25 16:45:34	1.54
--- generic/gdbtk-cmds.c	2002/04/01 22:26:57
*************** gdb_load_disassembly (ClientData clientD
*** 1672,1678 ****

    /* Now parse the addresses */

!   low = parse_and_eval_address (Tcl_GetStringFromObj (objv[5], NULL));
    orig = low;

    if (objc == 6)
--- 1672,1678 ----

    /* Now parse the addresses */

!   low = string_to_core_addr (Tcl_GetStringFromObj (objv[5], NULL));
    orig = low;

    if (objc == 6)
*************** gdb_load_disassembly (ClientData clientD
*** 1682,1688 ****
  	       paddr_nz (orig), Tcl_GetStringFromObj (objv[5], NULL));
      }
    else
!     high = parse_and_eval_address (Tcl_GetStringFromObj (objv[6], NULL));


    /* Setup the client_data structure, and call the driver function. */
--- 1682,1688 ----
  	       paddr_nz (orig), Tcl_GetStringFromObj (objv[5], NULL));
      }
    else
!     high = string_to_core_addr (Tcl_GetStringFromObj (objv[6], NULL));


    /* Setup the client_data structure, and call the driver function. */
*************** gdbtk_load_asm (ClientData clientData, C
*** 1978,1984 ****
        Tcl_DStringSetLength (&client_data->pc_to_line_prefix, pc_to_line_len);
        Tcl_DStringSetLength (&client_data->line_to_pc_prefix, line_to_pc_len);

!       free(buffer);
      }

    do_cleanups (old_chain);
--- 1978,1984 ----
        Tcl_DStringSetLength (&client_data->pc_to_line_prefix, pc_to_line_len);
        Tcl_DStringSetLength (&client_data->line_to_pc_prefix, line_to_pc_len);

!       xfree (buffer);
      }

    do_cleanups (old_chain);